From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 1/2] cfg80211: add support for setting the ad-hoc multicast rate
Date: Tue, 16 Nov 2010 15:45:55 -0800 [thread overview]
Message-ID: <1289951155.3673.17.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4CE3150A.7000300@openwrt.org>
On Wed, 2010-11-17 at 00:34 +0100, Felix Fietkau wrote:
> On 2010-11-16 11:27 PM, Johannes Berg wrote:
> > On Thu, 2010-11-11 at 15:07 +0100, Felix Fietkau wrote:
> >
> >> + if (info->attrs[NL80211_ATTR_MCAST_RATE])
> >> + ibss.mcast_rate =
> >> + nla_get_u32(info->attrs[NL80211_ATTR_MCAST_RATE]);
> >
> > That should really check that the rate is supported, and maybe that it's
> > a basic rate.
> But what about band changes then?
Yeah but what about them? You don't handle them anyway -- should maybe
do a per-band setting? Basically right now you end up ignoring the rate
if it's not available.
johannes
prev parent reply other threads:[~2010-11-16 23:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 14:07 [PATCH 1/2] cfg80211: add support for setting the ad-hoc multicast rate Felix Fietkau
2010-11-11 14:07 ` [PATCH 2/2] mac80211: " Felix Fietkau
2010-11-16 22:27 ` Johannes Berg
2010-11-17 3:00 ` Felix Fietkau
2010-11-16 22:27 ` [PATCH 1/2] cfg80211: " Johannes Berg
2010-11-16 23:34 ` Felix Fietkau
2010-11-16 23:45 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289951155.3673.17.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).