linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: wwguy <wey-yi.w.guy@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/5] iwlwifi: cleanup {iwl,iwl3945}_good_plcp_health
Date: Tue, 08 Feb 2011 07:24:05 -0800	[thread overview]
Message-ID: <1297178645.20613.28.camel@wwguy-ubuntu> (raw)
In-Reply-To: <1297153919-18766-2-git-send-email-sgruszka@redhat.com>

Hi Stanislaw,

On Tue, 2011-02-08 at 00:31 -0800, Stanislaw Gruszka wrote:
> Make plcp health code human readable.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
>  drivers/net/wireless/iwlwifi/iwl-3945.c     |   83 +++++++-----------
>  drivers/net/wireless/iwlwifi/iwl-agn-rx.c   |  122 +++++++++++----------------
>  drivers/net/wireless/iwlwifi/iwl-commands.h |    1 +
>  3 files changed, 80 insertions(+), 126 deletions(-)
> 

Thanks for the clean up, now is much easier to read.

Now we are very close to release the split driver, here you change both
agn and 3945, not sure what is the easier approach will be? push the
patch now, or wait for the driver split finish, then push the patch
after that.

Wey



  reply	other threads:[~2011-02-08 15:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08  8:31 [PATCH 1/5] iwlwifi: cleanup iwl_recover_from_statistics Stanislaw Gruszka
2011-02-08  8:31 ` [PATCH 2/5] iwlwifi: cleanup {iwl,iwl3945}_good_plcp_health Stanislaw Gruszka
2011-02-08 15:24   ` wwguy [this message]
2011-02-09  6:24     ` Stanislaw Gruszka
2011-02-09 17:03       ` wwguy
2011-02-08  8:31 ` [PATCH 3/5] iwlwifi: cleanup iwl_good_ack_health Stanislaw Gruszka
2011-02-08 15:32   ` wwguy
2011-02-08  8:31 ` [PATCH 4/5] iwlwifi: fix ack health for WiFi/BT combo devices Stanislaw Gruszka
2011-02-08 15:36   ` wwguy
2011-02-09  6:26     ` Stanislaw Gruszka
2011-02-09 17:04       ` wwguy
2011-02-08  8:31 ` [PATCH 5/5] iwlwifi: avoid too frequent recover from statistics Stanislaw Gruszka
2011-02-08 15:45   ` wwguy
2011-02-09  6:28     ` Stanislaw Gruszka
2011-02-09 17:05       ` wwguy
2011-02-08 15:16 ` [PATCH 1/5] iwlwifi: cleanup iwl_recover_from_statistics wwguy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297178645.20613.28.camel@wwguy-ubuntu \
    --to=wey-yi.w.guy@intel.com \
    --cc=ilw@linux.intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).