From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E2EDC3A5A2 for ; Tue, 3 Sep 2019 19:03:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1253722CF8 for ; Tue, 3 Sep 2019 19:03:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Djjic5/q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726602AbfICTDl (ORCPT ); Tue, 3 Sep 2019 15:03:41 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54668 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbfICTDl (ORCPT ); Tue, 3 Sep 2019 15:03:41 -0400 Received: by mail-wm1-f67.google.com with SMTP id k2so632046wmj.4 for ; Tue, 03 Sep 2019 12:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3pKB/s7QIRjzR74E3kb2LPD38Qsso7bn4uv9aOUYFW0=; b=Djjic5/qjFPywC0E5JslCge+wapy7Mva/hu5YL1n9HjKtPJNQ6hu78fIWeOmIbblbT 5gp56GpDlDDBb81thNZngnnrYJEh0eUMX5pbk/zWdPcLwUTCNoEyQ/HBr8cvgXiadXQ5 flMN/82gCjOhtQDS4xBsnU+4ZP43WvbzDZWsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3pKB/s7QIRjzR74E3kb2LPD38Qsso7bn4uv9aOUYFW0=; b=Gu41L29kdA4utlCaL309AGRThDgj3zxP0vkrO3q5Jzf1TKeIsnuuEHfSlW57SlUrOQ EVlnGO3jZnisHpnbueBEI2PGFhJOHT93a52mMxngVm6BbIXghrrOK2uciXiK0IYy8z9I 7p03PaXq1HghpdUp3Tj5GiITXqOyDILVyDyskvLWiL+GNsxrUk/hFxhO/oUZ2ULn3fRv vjQMYxucbPgT7VIn5ELcZ/EUXmuYrzWs5IEAqZNetV8fQ7winDWs0lK9eTNUmKWj4tbX feZDQc1l7RfUY/d3WU+qz2u1r1d7zJeTc/MHnoPor43LlRPDvnDgaRmsSxWm1rEAafsA VbNg== X-Gm-Message-State: APjAAAVJGq2yQec71qvvlZFPvKJi7qOrFxc/nNhutxiziU1hiCWx/C36 wcq9u/RPDB1nK3XEnKVuLIEeIGsdcnKTJA== X-Google-Smtp-Source: APXvYqxth98K0tShDu7b/q4uM/GyUqobljOmGn4ySzL3043chwPTK0pHCE5qUfrdNvB1O9P9GME7Bg== X-Received: by 2002:a1c:6c0c:: with SMTP id h12mr1019962wmc.162.1567537418937; Tue, 03 Sep 2019 12:03:38 -0700 (PDT) Received: from [10.230.33.15] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id 207sm826024wme.17.2019.09.03.12.03.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Sep 2019 12:03:38 -0700 (PDT) Subject: Re: [PATCH 2/3] brcmfmac: split brcmf_attach() and brcmf_detach() functions To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Kalle Valo Cc: Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Winnie Chang , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20190903042928.18621-1-zajec5@gmail.com> <20190903042928.18621-3-zajec5@gmail.com> From: Arend Van Spriel Message-ID: <12d6c6d0-4f7d-dc6a-5a5c-ade8585033fd@broadcom.com> Date: Tue, 3 Sep 2019 21:03:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190903042928.18621-3-zajec5@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 9/3/2019 6:29 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Move code allocating/freeing wiphy out of above functions. This will > allow reinitializing the driver (e.g. on some error) without allocating > a new wiphy. Acked-by: Arend van Spriel > Signed-off-by: Rafał Miłecki > --- > .../broadcom/brcm80211/brcmfmac/bus.h | 4 ++- > .../broadcom/brcm80211/brcmfmac/core.c | 33 ++++++++++++++---- > .../broadcom/brcm80211/brcmfmac/pcie.c | 13 +++++-- > .../broadcom/brcm80211/brcmfmac/sdio.c | 15 ++++++-- > .../broadcom/brcm80211/brcmfmac/usb.c | 34 +++++++++++++++---- > 5 files changed, 80 insertions(+), 19 deletions(-)