From: Johannes Berg <johannes@sipsolutions.net>
To: Paul Stewart <pstew@chromium.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] cfg80211: Fix handling of previous_auth deauth
Date: Wed, 08 Jun 2011 13:02:02 +0200 [thread overview]
Message-ID: <1307530922.3961.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <a194a41b3f1376f035113d4f443038eb2e64264f.1307403076.git.pstew@chromium.org> (sfid-20110607_013247_523227_4CDD0493)
On Mon, 2011-06-06 at 16:00 -0700, Paul Stewart wrote:
> The WLAN_REASON_PREV_AUTH_NOT_VALID DEAUTH message is sent
> to remove current successful authentications, not to to abort
> a new authentication attempts. Therefore, filter this reason
> code out when deciding whether to remove authtry_bsses[] entries.
>
> This is the least invasive change which prevents this issue
> from appearing.
Maybe I'm confused -- what's "this issue"?
> It doesn't address the fact that the mac80211
> code still retries authentications if it is DEAUTHed for some
> other reason during authentication. If one of those retries
> succeeds the client can do nothing with it sicne authtry_bsses[]
> has been cleared.
So basically you're getting a deauth while trying to auth? Rather than a
rejected auth? Hmm.
It seems mac80211 shouldn't pass such up since it isn't actually
connected. But then we just pass them up and rely on cfg80211 to sort it
out. Why do we even attempt to remove something from authtry_bsses when
receiving a deauth frame? This only makes sense when we sent it
ourselves and want to abort the authentication that way I guess?
johannes
next prev parent reply other threads:[~2011-06-08 11:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 23:00 [RFC] cfg80211: Fix handling of previous_auth deauth Paul Stewart
2011-06-08 11:02 ` Johannes Berg [this message]
[not found] ` <BANLkTimdAHt9VUUmNB2uzgm8ymeo6J+EeA@mail.gmail.com>
2011-06-08 11:44 ` Johannes Berg
2011-06-08 11:48 ` Paul Stewart
2011-06-08 11:50 ` Johannes Berg
2011-06-08 12:52 ` [PATCH] cfg80211: Ignore downstream DEAUTH for authtry_bsses Paul Stewart
2011-06-08 13:19 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307530922.3961.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pstew@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).