linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/5] mac80211: fix CTS protection handling
Date: Mon, 15 Apr 2013 15:40:31 +0200	[thread overview]
Message-ID: <1366033231.8361.24.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1365890626-86895-2-git-send-email-nbd@openwrt.org>

On Sun, 2013-04-14 at 00:03 +0200, Felix Fietkau wrote:

> @@ -655,7 +655,9 @@ struct ieee80211_tx_info {
>  					struct ieee80211_tx_rate rates[
>  						IEEE80211_TX_MAX_RATES];
>  					s8 rts_cts_rate_idx;
> -					/* 3 bytes free */
> +					u8 use_rts:1;
> +					u8 use_cts_prot:1;

hmm, why here?

> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -656,6 +656,9 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx)
>  		txrc.rts = rts = true;
>  	}
>  
> +	info->control.use_rts = rts;

evidently, txrc already has an "rts" field?

johannes


  parent reply	other threads:[~2013-04-15 13:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 22:03 [PATCH 1/5] mac80211: fix and optimize MCS mask handling Felix Fietkau
2013-04-13 22:03 ` [PATCH 2/5] mac80211: fix CTS protection handling Felix Fietkau
2013-04-13 22:03   ` [PATCH 3/5] mac80211: improve the rate control API Felix Fietkau
2013-04-13 22:03     ` [PATCH 4/5] mac80211/minstrel_ht: use the new " Felix Fietkau
2013-04-13 22:03       ` [PATCH 5/5] mac80211/minstrel: " Felix Fietkau
2013-04-15 13:44     ` [PATCH 3/5] mac80211: improve the " Johannes Berg
2013-04-15 14:27       ` Felix Fietkau
2013-04-16 10:03     ` Karl Beldan
2013-04-16 10:44       ` Felix Fietkau
2013-04-15 13:40   ` Johannes Berg [this message]
2013-04-15 14:24     ` [PATCH 2/5] mac80211: fix CTS protection handling Felix Fietkau
2013-04-15 13:38 ` [PATCH 1/5] mac80211: fix and optimize MCS mask handling Johannes Berg
2013-04-15 14:19   ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366033231.8361.24.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).