From: "DE CESCO, Jonathan" <jonathanc@ti.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "Coelho, Luciano" <coelho@ti.com>
Subject: wl12xx compat wireless rcu_read_lock issue
Date: Tue, 11 Jan 2011 11:22:57 +0100 [thread overview]
Message-ID: <13872098A06B02418CF379A158C0F146015BEB592B@dnce02.ent.ti.com> (raw)
In-Reply-To: <AANLkTimpDo=0AcL5OdEjnpB8-_o7XBJ5QT-mE-FmfZo6@mail.gmail.com>
Hi,
When trying to test wl12xx driver from compat-wireless-2010-12-13 (with a wl1273 device), I notice a crash when initializing the wlan interface.
Find below the patch that seems to solve the issue:
diff --git a/compat-wireless-2010-12-13/drivers/net/wireless/wl12xx/main.c b/compat-wireless-2010-12-13/drivers/net/wireless/wl12xx/main.c
index 1fc5a36..480f44b 100644
--- a/compat-wireless-2010-12-13/drivers/net/wireless/wl12xx/main.c
+++ b/compat-wireless-2010-12-13/drivers/net/wireless/wl12xx/main.c
@@ -1858,11 +1858,17 @@ static void wl1271_op_bss_info_changed(struct ieee80211_hw *hw,
{
enum wl1271_cmd_ps_mode mode;
struct wl1271 *wl = hw->priv;
- struct ieee80211_sta *sta = ieee80211_find_sta(vif, bss_conf->bssid);
+ rcu_read_lock();
+ struct ieee80211_sta *sta;
bool do_join = false;
bool set_assoc = false;
int ret;
+ sta = ieee80211_find_sta(vif, bss_conf->bssid);
+ if (!sta) {
+ rcu_read_unlock();
+ return;
+ }
wl1271_debug(DEBUG_MAC80211, "mac80211 bss info changed");
+ rcu_read_unlock();
mutex_lock(&wl->mutex);
--
Is this a known bug that has already been encountered? I am using the compat wireless flavor of the mac80211 framework and driver so I don't really know if you can come across this issue with standard kernel.
Thanks,
John
next prev parent reply other threads:[~2011-01-11 10:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 13:42 [PATCH 0/2] wl12xx: BA Initiator & receiver support Shahar Levi
2011-01-03 13:42 ` [PATCH v5 1/2] wl12xx: BA initiator support Shahar Levi
2011-01-10 15:00 ` Luciano Coelho
[not found] ` <AANLkTi=KnSjVVCN=9=PaL9_GYpDOpJFvD-LGxFXEevhw@mail.gmail.com>
2011-01-11 0:18 ` Levi, Shahar
2011-01-11 8:04 ` Luciano Coelho
2011-01-16 9:12 ` Levi, Shahar
2011-01-11 10:22 ` DE CESCO, Jonathan [this message]
2011-01-11 11:28 ` wl12xx compat wireless rcu_read_lock issue Luciano Coelho
[not found] ` <AANLkTi=4H6TXvXWi_KVBEn3G_aNW_8qZfBF7g36WRED6@mail.gmail.com>
2011-01-11 16:59 ` Luciano Coelho
2011-01-03 13:42 ` [PATCH v3 2/2] wl12xx: BA receiver support Shahar Levi
2011-01-10 15:44 ` Luciano Coelho
2011-01-11 0:54 ` Levi, Shahar
2011-01-16 13:38 ` Levi, Shahar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13872098A06B02418CF379A158C0F146015BEB592B@dnce02.ent.ti.com \
--to=jonathanc@ti.com \
--cc=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).