linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] mac80211: check if the ps_buf skb queue hasn't been drained
Date: Thu, 20 Feb 2014 09:26:35 +0100	[thread overview]
Message-ID: <1392884795.5073.6.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1392880931-18468-1-git-send-email-emmanuel.grumbach@intel.com>

On Thu, 2014-02-20 at 09:22 +0200, Emmanuel Grumbach wrote:

> Fix all this by syncing both path with sta_info->lock.

As I just found out, this causes a deadlock since we sometimes already
hold sta->lock while transmitting.

I'll change the patch to use a new lock, and then later will make a
separate patch to remove all the per-AC locks instead.

johannes


      reply	other threads:[~2014-02-20  8:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-20  6:18 [PATCH] mac80211: check if the ps_buf skb queue hasn't been drained Emmanuel Grumbach
2014-02-20  7:07 ` Johannes Berg
2014-02-20  7:22 ` [PATCH v2] " Emmanuel Grumbach
2014-02-20  8:26   ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392884795.5073.6.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=emmanuel.grumbach@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).