linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Paul Stewart <pstew@chromium.org>
Cc: linux-wireless@vger.kernel.org, Luca Coelho <luca@coelho.fi>
Subject: Re: [PATCHv2] nl80211: Provide TDLS link state
Date: Wed, 21 May 2014 12:41:30 +0200	[thread overview]
Message-ID: <1400668890.4136.1.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20140520223316.EFCF1E0007@pstew.mtv.corp.google.com> (sfid-20140521_003322_185995_CD232EF2)

On Tue, 2014-05-20 at 13:27 -0700, Paul Stewart wrote:
> Provide a method to query TDLS state in drivers that use the
> NL80211_CMD_TDLS_OPER method for link setup.

Apart from the fact that your patch isn't very clear on how this was
intended to be used (some return value?) I don't really see why even
such a driver couldn't implement station operations
(get_station/dump_station) and get the same API for this that mac80211
already implements.

iw wlan0 station dump gives me
Station 02:00:00:00:01:00 (on wlan0)
	inactive time:	450 ms
	rx bytes:	3068
	rx packets:	2
	tx bytes:	3036
	tx packets:	2
	tx retries:	0
	tx failed:	0
	signal:  	-30 dBm
	signal avg:	-30 dBm
	tx bitrate:	24.0 MBit/s
	rx bitrate:	12.0 MBit/s
	authorized:	yes
	authenticated:	yes
	preamble:	long
	WMM/WME:	no
	MFP:		no
	TDLS peer:	yes
[...]


johannes


  reply	other threads:[~2014-05-21 10:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20 20:27 [PATCH] nl80211: Provide TDLS link state Paul Stewart
2014-05-20 21:54 ` Luca Coelho
2014-05-20 20:27   ` [PATCHv2] " Paul Stewart
2014-05-21 10:41     ` Johannes Berg [this message]
2014-05-21 16:17       ` Paul Stewart
2014-05-21 19:59         ` Johannes Berg
2014-05-21 20:19           ` Paul Stewart
2014-05-22  6:56             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400668890.4136.1.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luca@coelho.fi \
    --cc=pstew@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).