From: Michal Kazior <michal.kazior@tieto.com>
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, Michal Kazior <michal.kazior@tieto.com>
Subject: [PATCH 1/7] ath10k: allow empty ssid vdev config
Date: Fri, 30 Jan 2015 09:41:21 +0100 [thread overview]
Message-ID: <1422607287-12289-2-git-send-email-michal.kazior@tieto.com> (raw)
In-Reply-To: <1422607287-12289-1-git-send-email-michal.kazior@tieto.com>
It doesn't make much sense to reject a valid
firmware configuration combination.
Since SSID isn't known early on it might make
sense to allow driver to start vdev without SSID
and restart it later.
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
---
drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 --
drivers/net/wireless/ath/ath10k/wmi.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
index be32db9..ccafb69 100644
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
@@ -1302,8 +1302,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar,
void *ptr;
u32 flags = 0;
- if (WARN_ON(arg->ssid && arg->ssid_len == 0))
- return ERR_PTR(-EINVAL);
if (WARN_ON(arg->hidden_ssid && !arg->ssid))
return ERR_PTR(-EINVAL);
if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index ce6f0c7..97ee2e9 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -4264,8 +4264,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar,
const char *cmdname;
u32 flags = 0;
- if (WARN_ON(arg->ssid && arg->ssid_len == 0))
- return ERR_PTR(-EINVAL);
if (WARN_ON(arg->hidden_ssid && !arg->ssid))
return ERR_PTR(-EINVAL);
if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))
--
1.8.5.3
next prev parent reply other threads:[~2015-01-30 8:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 8:41 [PATCH 0/7] ath10k: add multi-channel support Michal Kazior
2015-01-30 8:41 ` Michal Kazior [this message]
2015-01-30 8:41 ` [PATCH 2/7] ath10k: implement chanctx API Michal Kazior
2015-01-30 10:44 ` Michal Kazior
2015-01-30 8:41 ` [PATCH 3/7] ath10k: implement adaptive qcs command Michal Kazior
2015-01-30 8:41 ` [PATCH 4/7] ath10k: protect ar->arvifs linking with data_lock Michal Kazior
2015-01-30 8:41 ` [PATCH 5/7] ath10k: rework tx queue locking Michal Kazior
2015-01-30 8:41 ` [PATCH 6/7] ath10k: implement tx pause wmi event Michal Kazior
2015-01-30 8:41 ` [PATCH 7/7] ath10k: enable multi-channel on supported devices Michal Kazior
2015-01-30 12:31 ` [PATCH v2 0/7] ath10k: add multi-channel support Michal Kazior
2015-01-30 12:31 ` [PATCH v2 1/7] ath10k: allow empty ssid vdev config Michal Kazior
2015-01-30 12:31 ` [PATCH v2 2/7] ath10k: implement chanctx API Michal Kazior
2015-01-30 12:45 ` Johannes Berg
2015-01-30 13:02 ` Michal Kazior
2015-01-30 13:04 ` Johannes Berg
2015-01-30 13:22 ` Michal Kazior
2015-01-30 13:31 ` Johannes Berg
2015-01-30 13:47 ` Michal Kazior
2015-01-30 14:06 ` Johannes Berg
2015-01-30 12:58 ` Johannes Berg
2015-01-30 13:06 ` Michal Kazior
2015-01-30 13:10 ` Johannes Berg
2015-01-30 14:01 ` Michal Kazior
2015-01-30 14:10 ` Johannes Berg
2015-01-30 12:31 ` [PATCH v2 3/7] ath10k: implement adaptive qcs command Michal Kazior
2015-01-30 12:31 ` [PATCH v2 4/7] ath10k: protect ar->arvifs linking with data_lock Michal Kazior
2015-01-30 12:31 ` [PATCH v2 5/7] ath10k: rework tx queue locking Michal Kazior
2015-01-30 12:31 ` [PATCH v2 6/7] ath10k: implement tx pause wmi event Michal Kazior
2015-01-30 12:31 ` [PATCH v2 7/7] ath10k: enable multi-channel on supported devices Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422607287-12289-2-git-send-email-michal.kazior@tieto.com \
--to=michal.kazior@tieto.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).