From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
To: linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: [PATCH 25/31] iwlwifi: mvm: remove unused arguments
Date: Thu, 2 Apr 2015 09:41:13 +0300 [thread overview]
Message-ID: <1427956879-11725-25-git-send-email-emmanuel.grumbach@intel.com> (raw)
In-Reply-To: <1427956656.8122.2.camel@egrumbacBox>
From: Johannes Berg <johannes.berg@intel.com>
The str/len arguments to iwl_fw_dbg_trigger_simple_stop() aren't used,
and for a simple trigger don't really need to be used as the trigger
code itself encodes the reason, so remove them.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
drivers/net/wireless/iwlwifi/mvm/mac80211.c | 3 +--
drivers/net/wireless/iwlwifi/mvm/mvm.h | 5 ++---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/iwlwifi/mvm/mac80211.c
index 0bd3373..810b6d3 100644
--- a/drivers/net/wireless/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/iwlwifi/mvm/mac80211.c
@@ -3711,8 +3711,7 @@ static int iwl_mvm_pre_channel_switch(struct ieee80211_hw *hw,
IWL_DEBUG_MAC80211(mvm, "pre CSA to freq %d\n",
chsw->chandef.center_freq1);
- iwl_fw_dbg_trigger_simple_stop(mvm, vif, FW_DBG_TRIGGER_CHANNEL_SWITCH,
- NULL, 0);
+ iwl_fw_dbg_trigger_simple_stop(mvm, vif, FW_DBG_TRIGGER_CHANNEL_SWITCH);
switch (vif->type) {
case NL80211_IFTYPE_AP:
diff --git a/drivers/net/wireless/iwlwifi/mvm/mvm.h b/drivers/net/wireless/iwlwifi/mvm/mvm.h
index a3f2078..500064f 100644
--- a/drivers/net/wireless/iwlwifi/mvm/mvm.h
+++ b/drivers/net/wireless/iwlwifi/mvm/mvm.h
@@ -1516,8 +1516,7 @@ iwl_fw_dbg_trigger_check_stop(struct iwl_mvm *mvm,
static inline void
iwl_fw_dbg_trigger_simple_stop(struct iwl_mvm *mvm,
struct ieee80211_vif *vif,
- enum iwl_fw_dbg_trigger trig,
- const char *str, size_t len)
+ enum iwl_fw_dbg_trigger trig)
{
struct iwl_fw_dbg_trigger_tlv *trigger;
@@ -1528,7 +1527,7 @@ iwl_fw_dbg_trigger_simple_stop(struct iwl_mvm *mvm,
if (!iwl_fw_dbg_trigger_check_stop(mvm, vif, trigger))
return;
- iwl_mvm_fw_dbg_collect_trig(mvm, trigger, str, len);
+ iwl_mvm_fw_dbg_collect_trig(mvm, trigger, NULL, 0);
}
#endif /* __IWL_MVM_H__ */
--
1.9.1
next prev parent reply other threads:[~2015-04-02 6:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 6:37 pull request: iwlwifi-next 2015-04-02 Grumbach, Emmanuel
2015-04-02 6:40 ` [PATCH 01/31] iwlwifi: mvm: continue (with error) CSA on GO time event failure Emmanuel Grumbach
2015-04-02 6:40 ` [PATCH 02/31] iwlwifi: mvm: assign new TLV bit for multi-source LAR Emmanuel Grumbach
2015-04-02 6:40 ` [PATCH 03/31] iwlwifi: pcie: add rx packet sequence number to dbg print Emmanuel Grumbach
2015-04-02 6:40 ` [PATCH 04/31] iwlwifi: mvm: properly flush the queues for buffering transport Emmanuel Grumbach
2015-04-02 6:40 ` [PATCH 05/31] iwlwifi: mvm: add iccm data to 8000 b-step data dump Emmanuel Grumbach
2015-04-02 6:40 ` [PATCH 06/31] iwlwifi: mvm: remove time-event start/end failure warning Emmanuel Grumbach
2015-04-02 6:40 ` [PATCH 07/31] iwlwifi: mvm: don't wait for firmware verification Emmanuel Grumbach
2015-04-02 6:40 ` [PATCH 08/31] iwlwifi: mvm: take IWL_MVM_REF_UCODE_DOWN before restarting hw Emmanuel Grumbach
2015-04-02 6:40 ` [PATCH 09/31] iwlwifi: mvm: remove d0i3 ref correctly during AP start Emmanuel Grumbach
2015-04-02 6:40 ` [PATCH 10/31] iwlwifi: mvm: inform mac80211 about umac scans that was aborted by restart Emmanuel Grumbach
2015-04-02 6:40 ` [PATCH 11/31] iwlwifi: pcie: initialize trans_pcie->ref_count on configure() Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 12/31] iwlwifi: mvm: add delay to scheduled scan Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 13/31] iwlwifi: mvm: use debugfs_create_bool() for enable_scan_iteration_notif Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 14/31] iwlwifi: drop support for early versions of 8000 Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 15/31] iwlwifi: mvm: allow to configure the timeout for the Tx queues Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 16/31] iwlwifi: mvm: fix debug print in the RSA ownership workaround Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 17/31] iwlwifi: 8000: change PNVM in case it doesn't match to the HW step Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 18/31] iwlwifi: mvm: Clean up UMAC scan UIDs in the reset and drv_stop flows Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 19/31] iwlwifi: mvm: rs: fix comment indentation Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 20/31] iwlwifi: check the size of the trigger struct from the firmware file Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 21/31] iwlwifi: mvm: rs: refactor rs_update_rate_tbl Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 22/31] iwlwifi: mvm: add debugfs entry with the number of net-detect scans Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 23/31] iwlwifi: mvm: always reconfigure last MCC on init Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 24/31] iwlwifi: mvm: Fix wrongfully flushing frames in the roc/off channel queue Emmanuel Grumbach
2015-04-02 6:41 ` Emmanuel Grumbach [this message]
2015-04-02 6:41 ` [PATCH 26/31] iwlwifi: mvm: add trigger for firmware dump upon MLME failures Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 27/31] iwlwifi: mvm: don't return uninitialized value in get_survey() Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 28/31] iwlwifi: fix spelling errors Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 29/31] iwlwifi: mvm: do string formatting in debug triggers Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 30/31] iwlwifi: mvm: add trigger for time events Emmanuel Grumbach
2015-04-02 6:41 ` [PATCH 31/31] iwlwifi: mvm: capture connection loss as part of MLME trigger Emmanuel Grumbach
2015-04-07 17:06 ` pull request: iwlwifi-next 2015-04-02 Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427956879-11725-25-git-send-email-emmanuel.grumbach@intel.com \
--to=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).