From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:33278 "EHLO lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbbESICU (ORCPT ); Tue, 19 May 2015 04:02:20 -0400 Message-ID: <1432022535.9091.48.camel@x220> (sfid-20150519_100226_362219_68E4E540) Subject: Re: [PATCH v1 03/12] crypto: qat - address recursive dependency when fw signing is enabled From: Paul Bolle To: "Luis R. Rodriguez" Cc: Herbert Xu , "Luis R. Rodriguez" , rusty@rustcorp.com.au, dhowells@redhat.com, ming.lei@canonical.com, seth.forshee@canonical.com, kyle@kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, keescook@chromium.org, casey@schaufler-ca.com, tiwai@suse.de, mjg59@srcf.ucam.org, wireless-regdb@lists.infradead.org, linux-wireless@vger.kernel.org, jlee@suse.com, linux-kernel@vger.kernel.org, Bruce Allan , Tadeusz Struk , John Griffin Date: Tue, 19 May 2015 10:02:15 +0200 In-Reply-To: <20150519000921.GA23057@wotan.suse.de> References: <1430873070-7290-1-git-send-email-mcgrof@do-not-panic.com> <1430873070-7290-4-git-send-email-mcgrof@do-not-panic.com> <20150506033330.GA16470@gondor.apana.org.au> <1430988137.8171.58.camel@x220> <1431021995.8171.97.camel@x220> <20150518200100.GY23057@wotan.suse.de> <1431981930.9091.29.camel@x220> <20150519000921.GA23057@wotan.suse.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2015-05-19 at 02:09 +0200, Luis R. Rodriguez wrote: > On Mon, May 18, 2015 at 10:45:30PM +0200, Paul Bolle wrote: > > [...] so, probably, almost > > all .config files have FW_LOADER set. So I think, except for some corner > > cases, either converting all "select FW_LOADER" to "depends on > > FW_LOADER" or simply dropping "select FW_LOADER" all together, should > > be fine. > > Well, that makes sense. I just dropped all "select FW_LOADER" entries > on next-20150518, then I enabled everything with 'make allyesconfig' > and then went into menuconfig to disable FW_LOADER. The build worked. > > Going to try a few more build matrix combinations and send patches to > do away with this. > > > Those corner cases should then be handled on a case by case basis. Having slept on this, it occurred to me a randconfig could hit those corner cases. (Make that will hit them, actually.) Of course, one might argue that randconfig and EXPERT's advice, "Only use this if you really know what you are doing.", are at odds. Which opens another can of worms: how much do we care about .config files in which randconfig visited the kernels darker corners? Just enough, I'm afraid. So it seems I've wasted your time by suggesting to drop those selects. And now I wonder what trouble using "depends on" will generate here... Paul Bolle