From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mac80211: fix AP_VLAN crypto tailroom calculation
Date: Wed, 20 May 2015 15:12:04 +0200 [thread overview]
Message-ID: <1432127524.19214.11.camel@sipsolutions.net> (raw)
In-Reply-To: <1431508609-9841-1-git-send-email-michal.kazior@tieto.com> (sfid-20150513_111659_239981_BA392FBA)
On Wed, 2015-05-13 at 09:16 +0000, Michal Kazior wrote:
> Some splats I was seeing:
>
> (a) WARNING: CPU: 1 PID: 0 at /devel/src/linux/net/mac80211/wep.c:102 ieee80211_wep_add_iv
> (b) WARNING: CPU: 1 PID: 0 at /devel/src/linux/net/mac80211/wpa.c:73 ieee80211_tx_h_michael_mic_add
> (c) WARNING: CPU: 3 PID: 0 at /devel/src/linux/net/mac80211/wpa.c:433 ieee80211_crypto_ccmp_encrypt
>
> I've seen (a) and (b) with ath9k hw crypto and (c)
> with ath9k sw crypto. All of them were related to
> insufficient skb tailroom and I was able to
> trigger these with ping6 program.
>
> AP_VLANs may inherit crypto keys from parent AP.
> This wasn't considered and yielded problems in
> some setups resulting in inability to transmit
> data because mac80211 wouldn't resize skbs when
> necessary and subsequently drop some packets due
> to insufficient tailroom.
>
> For efficiency purposes don't inspect both AP_VLAN
> and AP sdata looking for tailroom counter. Instead
> update AP_VLAN tailroom counters whenever their
> master AP tailroom counter changes.
Applied.
johannes
prev parent reply other threads:[~2015-05-20 13:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 13:05 [PATCH] mac80211: fix AP_VLAN crypto tailroom calculation Michal Kazior
2015-05-11 13:11 ` Johannes Berg
2015-05-11 13:33 ` Michal Kazior
2015-05-13 9:16 ` [PATCH v2 1/2] " Michal Kazior
2015-05-13 9:16 ` [PATCH v2 2/2] mac80211: prevent possible crypto tx tailroom corruption Michal Kazior
2015-05-20 13:14 ` Johannes Berg
2015-05-21 8:16 ` Michal Kazior
2015-05-21 8:30 ` Johannes Berg
2015-05-21 8:44 ` Michal Kazior
2015-05-22 8:22 ` [PATCH v3] " Michal Kazior
2015-05-29 11:05 ` Johannes Berg
2015-05-20 13:12 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432127524.19214.11.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).