linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
To: linux-wireless@vger.kernel.org
Cc: Eliad Peller <eliad@wizery.com>,
	Eliad Peller <eliadx.peller@intel.com>,
	Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: [PATCH 34/39] iwlwifi: tracing: add rx cmd header fields
Date: Tue, 26 May 2015 22:17:47 +0300	[thread overview]
Message-ID: <1432667872-18092-34-git-send-email-emmanuel.grumbach@intel.com> (raw)
In-Reply-To: <1432667798.26624.3.camel@intel.com>

From: Eliad Peller <eliad@wizery.com>

Having explicit rx cmd header fields is useful, as it can
be used for event filtering (e.g. saving only debug logs,
rather than the whole data)

Signed-off-by: Eliad Peller <eliadx.peller@intel.com>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
 drivers/net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h b/drivers/net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h
index 223b875..948ce08 100644
--- a/drivers/net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h
+++ b/drivers/net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h
@@ -1,6 +1,7 @@
 /******************************************************************************
  *
  * Copyright(c) 2009 - 2014 Intel Corporation. All rights reserved.
+ * Copyright(c) 2015 Intel Mobile Communications GmbH
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of version 2 of the GNU General Public License as
@@ -64,19 +65,21 @@ TRACE_EVENT(iwlwifi_dev_hcmd,
 
 TRACE_EVENT(iwlwifi_dev_rx,
 	TP_PROTO(const struct device *dev, const struct iwl_trans *trans,
-		 void *rxbuf, size_t len),
-	TP_ARGS(dev, trans, rxbuf, len),
+		 struct iwl_rx_packet *pkt, size_t len),
+	TP_ARGS(dev, trans, pkt, len),
 	TP_STRUCT__entry(
 		DEV_ENTRY
-		__dynamic_array(u8, rxbuf, iwl_rx_trace_len(trans, rxbuf, len))
+		__field(u8, cmd)
+		__dynamic_array(u8, rxbuf, iwl_rx_trace_len(trans, pkt, len))
 	),
 	TP_fast_assign(
 		DEV_ASSIGN;
-		memcpy(__get_dynamic_array(rxbuf), rxbuf,
-		       iwl_rx_trace_len(trans, rxbuf, len));
+		__entry->cmd = pkt->hdr.cmd;
+		memcpy(__get_dynamic_array(rxbuf), pkt,
+		       iwl_rx_trace_len(trans, pkt, len));
 	),
 	TP_printk("[%s] RX cmd %#.2x",
-		  __get_str(dev), ((u8 *)__get_dynamic_array(rxbuf))[4])
+		  __get_str(dev), __entry->cmd)
 );
 
 TRACE_EVENT(iwlwifi_dev_tx,
-- 
2.1.4


  parent reply	other threads:[~2015-05-26 19:19 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 19:16 pull request: iwlwifi-next 2015-05-26 Grumbach, Emmanuel
2015-05-26 19:17 ` [PATCH 01/39] iwlwifi: pcie: don't call set_pwr functions for family 8000 Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 02/39] iwlwifi: mvm: fix ROC reference accounting Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 03/39] iwlwifi: pcie: fix tracking of cmd_in_flight Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 04/39] iwlwifi: Remove use of the deprecacted PTR_RET Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 05/39] iwlwifi: mvm: small fix in a comment about UMAC scan schedules Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 06/39] iwlwifi: refactor common transport alloc/init code Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 07/39] iwlwifi: dump API to 14 Emmanuel Grumbach
2015-05-26 19:39   ` Rafał Miłecki
2015-05-27 19:01     ` Grumbach, Emmanuel
2015-05-26 19:17 ` [PATCH 08/39] iwlwifi: pcie: simplify return value Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 09/39] iwlwifi: mvm: Add debugfs entry for Tx power limit Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 10/39] iwlwifi: 8000: fallback to default NVM file Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 11/39] iwlwifi: update thermal throttling values for 8000 devices Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 12/39] iwlwifi: mvm: advertise randomised netdetect MAC address Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 13/39] iwlwifi: mvm: handle device start failure correctly Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 14/39] iwlwifi: mvm: Configure agg. queue before assigning it to STA Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 15/39] iwlwifi: mvm: remove the UMAC specific scan types Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 16/39] iwlwifi: mvm: BT Coex - remove useless code Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 17/39] iwlwifi: mvm: BT Coex - allocate a short command on the stack Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 18/39] iwlwifi: mvm: print scanned channel list on scan iteration complete notification Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 19/39] iwlwifi: mvm: add UMAC " Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 20/39] iwlwifi: mvm: fix the net-detect SSIDs report order Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 21/39] iwlwifi: mvm: make iwl_mvm_config_sched_scan_profiles() static Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 22/39] iwlwifi: mvm: BT Coex - fix shared antenna check with new API Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 23/39] iwlwifi: mvm: reorganize scan stopping functions Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 24/39] iwlwifi: mvm: don't stop regular scans when going out of idle state Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 25/39] iwlwifi: mvm: combine part of the scan stop flows Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 26/39] iwlwifi: mvm: rename umac scan stop function Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 27/39] iwlwifi: mvm: rename some LMAC-specific scan functions Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 28/39] iwlwifi: mvm: add support for 8 level scan priority API Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 29/39] iwlwifi: mvm: refactor UMAC scan UID handling Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 30/39] iwlwifi: mvm: remove code that stops multiple UMAC scans of a type Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 31/39] iwlwifi: mvm: combine UMAC and LMAC scan_stop functions Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 32/39] iwlwifi: nvm: fix otp parsing in 8000 hw family Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 33/39] iwlwifi: pcie: Remove redundant check for family type Emmanuel Grumbach
2015-05-26 19:17 ` Emmanuel Grumbach [this message]
2015-05-26 19:17 ` [PATCH 35/39] iwlwifi: mvm: combine regular and sched scan stop functions Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 36/39] iwlwifi: mvm: make UMAC scans use the stopping scan status Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 37/39] iwlwifi: mvm: treat scan races also on UMAC scans Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 38/39] iwlwifi: mvm: implement the BlockAck related debug triggers Emmanuel Grumbach
2015-05-26 19:17 ` [PATCH 39/39] iwlwifi: mvm: clean interfaces on drv_stop Emmanuel Grumbach
2015-05-28  9:11 ` pull request: iwlwifi-next 2015-05-26 Kalle Valo
2015-05-28  9:25   ` Grumbach, Emmanuel
2015-05-28  9:43     ` Rafał Miłecki
2015-05-28 10:20     ` Kalle Valo
2015-05-28 10:25       ` Grumbach, Emmanuel
2015-05-28 11:15 ` pull request: iwlwifi-next 2015-05-28 Grumbach, Emmanuel
2015-06-03  7:07   ` Kalle Valo
2015-06-03  7:12     ` Grumbach, Emmanuel
2015-06-03  7:18       ` Kalle Valo
2015-06-03  7:24       ` pull request: iwlwifi-next 2015-06-03 Grumbach, Emmanuel
2015-06-03  7:30         ` Grumbach, Emmanuel
2015-06-03  9:26           ` Kalle Valo
2015-06-03  7:31         ` [PATCH 01/15] iwlwifi: mvm: rs: pass rate directly to column checks Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 02/15] iwlwifi: wrt: add mipi type to debug types Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 03/15] iwlwifi: pcie: Control access to the NIC's PM registers via iwl_cfg Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 04/15] iwlwifi: mvm: add inactive state to ebs status Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 05/15] iwlwifi: mvm: don't use EBS for P2P find Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 06/15] iwlwifi: pcie: re-enable interrupts on resume Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 07/15] iwlwifi: pcie: New RBD allocation model Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 08/15] iwlwifi: mvm: enable IEEE80211_HW_SUPPORT_FAST_XMIT Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 09/15] iwlwifi: dvm: " Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 10/15] iwlwifi: mvm: simplify iwl_mvm_stop_roc() Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 11/15] iwlwifi: prepare for higher API/CAPA bits Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 12/15] iwlwifi: mvm: Remove old scan commands Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 13/15] iwlwifi: mvm: Add DC2DC_CONFIG_CMD (0x83) cmd & TLV Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 14/15] iwlwifi: bump the iwlmvm API number to 15 Emmanuel Grumbach
2015-06-03  7:31         ` [PATCH 15/15] iwlwifi: mvm: advertise only HW-supported ciphers Emmanuel Grumbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432667872-18092-34-git-send-email-emmanuel.grumbach@intel.com \
    --to=emmanuel.grumbach@intel.com \
    --cc=eliad@wizery.com \
    --cc=eliadx.peller@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).