From: Glen Lee <glen.lee@atmel.com>
To: <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-wireless@vger.kernel.org>,
<tony.cho@atmel.com>, <glen.lee@atmel.com>, <leo.kim@atmel.com>,
<austin.shin@atmel.com>, <adel.noureldin@atmel.com>,
<adham.abozaeid@atmel.com>, <Nicolas.FERRE@atmel.com>
Subject: [PATCH 06/10] staging: wilc1000: wilc_init(): fixes inconsistent returns
Date: Wed, 25 Nov 2015 11:59:45 +0900 [thread overview]
Message-ID: <1448420389-4192-6-git-send-email-glen.lee@atmel.com> (raw)
In-Reply-To: <1448420389-4192-1-git-send-email-glen.lee@atmel.com>
From: Leo Kim <leo.kim@atmel.com>
This patch fixes the warning reported by smatch.
- wilc_init() warn: inconsistent returns 'sem:&hif_drv->sem_cfg_values'
No need to up the sema here since down was not called before get here.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
---
drivers/staging/wilc1000/host_interface.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index da4f4c6..3aea6ec 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3940,7 +3940,6 @@ s32 wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
return result;
_fail_timer_2:
- up(&hif_drv->sem_cfg_values);
del_timer_sync(&hif_drv->connect_timer);
del_timer_sync(&hif_drv->scan_timer);
kthread_stop(hif_thread_handler);
--
1.9.1
next prev parent reply other threads:[~2015-11-25 2:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 2:59 [PATCH 01/10] staging: wilc1000: fix rmmod failure Glen Lee
2015-11-25 2:59 ` [PATCH 02/10] staging: wilc1000: wilc_wfi_cfgoperations.c: remove over-commenting Glen Lee
2015-11-25 2:59 ` [PATCH 03/10] staging: wilc1000: fixes blank lines aren't necessary brace Glen Lee
2015-11-25 2:59 ` [PATCH 04/10] staging: wilc1000: replace explicit NULL comparisons with ! Glen Lee
2015-11-25 2:59 ` [PATCH 05/10] staging: wilc1000: fixes potential null dereference 'wid.val' Glen Lee
2015-11-25 2:59 ` Glen Lee [this message]
2015-11-25 2:59 ` [PATCH 07/10] staging: wilc1000: wilc_deinit(): fixes inconsistent returns Glen Lee
2015-11-25 2:59 ` [PATCH 08/10] staging: wilc1000: Handle_AddBASession: remove unused function Glen Lee
2015-11-25 2:59 ` [PATCH 09/10] staging: wilc1000: change if with else if Glen Lee
2015-11-25 2:59 ` [PATCH 10/10] staging: wilc1000: Handle_SetMulticastFilter(): fixes right shifting more than type allows Glen Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448420389-4192-6-git-send-email-glen.lee@atmel.com \
--to=glen.lee@atmel.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=adel.noureldin@atmel.com \
--cc=adham.abozaeid@atmel.com \
--cc=austin.shin@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).