From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH] mac80211: fix memory leak
Date: Fri, 29 Jan 2016 15:19:04 +0530 [thread overview]
Message-ID: <1454060944-11320-1-git-send-email-sudipm.mukherjee@gmail.com> (raw)
On error we jumped to the error label and returned the error code but we
missed releasing sinfo.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
net/mac80211/sta_info.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index 6c198e6..36e75c4 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -561,6 +561,7 @@ static int sta_info_insert_finish(struct sta_info *sta) __acquires(RCU)
__cleanup_single_sta(sta);
out_err:
mutex_unlock(&local->sta_mtx);
+ kfree(sinfo);
rcu_read_lock();
return err;
}
--
1.9.1
next reply other threads:[~2016-01-29 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 9:49 Sudip Mukherjee [this message]
2016-02-01 0:03 ` [PATCH] mac80211: fix memory leak Julian Calaby
2016-02-01 4:25 ` Sudip Mukherjee
2016-02-01 4:30 ` Julian Calaby
2016-02-01 9:28 ` Kalle Valo
2016-02-01 9:33 ` Sudip Mukherjee
2016-02-01 10:23 ` Julian Calaby
2016-02-01 12:57 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2015-05-20 9:37 Johannes Berg
2014-02-06 19:01 Emmanuel Grumbach
2014-02-11 11:59 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454060944-11320-1-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).