From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
To: linux-wireless@vger.kernel.org
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: [PATCH 07/31] iwlwifi: various comments and code cleanups
Date: Sun, 31 Jan 2016 13:06:02 +0200 [thread overview]
Message-ID: <1454238386-27032-7-git-send-email-emmanuel.grumbach@intel.com> (raw)
In-Reply-To: <0BA3FCBA62E2DC44AF3030971E174FB32E9F363A@hasmsx107.ger.corp.intel.com>
No need to include net/ip6_checksum.h twice.
Remove TODOs.
Remove trailing space.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
drivers/net/wireless/intel/iwlwifi/iwl-trans.h | 2 +-
drivers/net/wireless/intel/iwlwifi/mvm/fw-api-rx.h | 3 ---
drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 1 -
drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 1 -
4 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h b/drivers/net/wireless/intel/iwlwifi/iwl-trans.h
index e6a5e99..0ca0f13 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-trans.h
@@ -506,7 +506,7 @@ struct iwl_trans_config {
bool sw_csum_tx;
const struct iwl_hcmd_arr *command_groups;
int command_groups_size;
-
+
u32 sdio_adma_addr;
};
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw-api-rx.h b/drivers/net/wireless/intel/iwlwifi/mvm/fw-api-rx.h
index fb6d341..ab467cb 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw-api-rx.h
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw-api-rx.h
@@ -287,16 +287,13 @@ enum iwl_rx_mpdu_status {
IWL_RX_MPDU_STATUS_KEY_ERROR = BIT(4),
IWL_RX_MPDU_STATUS_ICV_OK = BIT(5),
IWL_RX_MPDU_STATUS_MIC_OK = BIT(6),
- /* TODO - verify this is the correct value */
IWL_RX_MPDU_RES_STATUS_TTAK_OK = BIT(7),
IWL_RX_MPDU_STATUS_SEC_MASK = 0x7 << 8,
IWL_RX_MPDU_STATUS_SEC_NONE = 0x0 << 8,
IWL_RX_MPDU_STATUS_SEC_WEP = 0x1 << 8,
IWL_RX_MPDU_STATUS_SEC_CCM = 0x2 << 8,
IWL_RX_MPDU_STATUS_SEC_TKIP = 0x3 << 8,
- /* TODO - define IWL_RX_MPDU_STATUS_SEC_EXT_ENC - this is a stub */
IWL_RX_MPDU_STATUS_SEC_EXT_ENC = 0x4 << 8,
- /* TODO - define IWL_RX_MPDU_STATUS_SEC_GCM - this is a stub */
IWL_RX_MPDU_STATUS_SEC_GCM = 0x5 << 8,
IWL_RX_MPDU_STATUS_DECRYPTED = BIT(11),
IWL_RX_MPDU_STATUS_WEP_MATCH = BIT(12),
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
index 89ea70d..6bf2bde 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
@@ -392,7 +392,6 @@ static const struct iwl_hcmd_arr iwl_mvm_groups[] = {
[PHY_OPS_GROUP] = HCMD_ARR(iwl_mvm_phy_names),
};
-
/* this forward declaration can avoid to export the function */
static void iwl_mvm_async_handlers_wk(struct work_struct *wk);
static void iwl_mvm_d0i3_exit_work(struct work_struct *wk);
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/tx.c b/drivers/net/wireless/intel/iwlwifi/pcie/tx.c
index c499345..837a7d5 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/tx.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/tx.c
@@ -34,7 +34,6 @@
#include <linux/sched.h>
#include <net/ip6_checksum.h>
#include <net/tso.h>
-#include <net/ip6_checksum.h>
#include "iwl-debug.h"
#include "iwl-csr.h"
--
2.5.0
next prev parent reply other threads:[~2016-01-31 11:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 11:05 pull request: iwlwifi-next 2016-01-31 Grumbach, Emmanuel
2016-01-31 11:05 ` [PATCH 01/31] iwlwifi: pcie: buffer packets to avoid overflowing Tx queues Emmanuel Grumbach
2016-01-31 11:05 ` [PATCH 02/31] iwlwifi: pcie: add infrastructure for multi-queue rx Emmanuel Grumbach
2016-01-31 11:05 ` [PATCH 03/31] iwlwifi: pcie: add 9000 series multi queue rx DMA support Emmanuel Grumbach
2016-01-31 11:05 ` [PATCH 04/31] iwlwifi: pcie: add initial RTPM support for PCI Emmanuel Grumbach
2016-02-01 14:32 ` Kalle Valo
2016-02-01 14:38 ` Grumbach, Emmanuel
2016-02-01 14:43 ` Grumbach, Emmanuel
2016-01-31 11:06 ` [PATCH 05/31] iwlwifi: pcie: add RTPM support when wifi is enabled Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 06/31] iwlwifi: mvm: Do not switch to D3 image on suspend Emmanuel Grumbach
2016-01-31 11:06 ` Emmanuel Grumbach [this message]
2016-01-31 11:06 ` [PATCH 08/31] iwlwifi: dvm: handle zero brightness for wifi LED Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 09/31] iwlwifi: Document missing module options Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 10/31] iwlwifi: mvm: add trigger for firmware dump upon TX response status Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 11/31] iwlwifi: mvm: Add P2P client snoozing Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 12/31] iwlwifi: mvm: make collecting fw debug data optional Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 13/31] iwlwifi: mvm: remove shadowing variable Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 14/31] iwlwifi: mvm: fix debugfs signedness warning Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 15/31] iwlwifi: mvm: add support for negative temperatures Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 16/31] iwlwifi: mvm: support beacon storing Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 17/31] iwlwifi: mvm: track low-latency sources separately Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 18/31] iwlwifi: mvm: support setting minimum quota from debugfs Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 19/31] iwlwifi: mvm: change access to ieee80211_hdr Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 20/31] iwlwifi: mvm: add debug print if scan config is ignored Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 21/31] iwlwifi: mvm: change the check for ADD_STA status Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 22/31] iwlwifi: mvm: add tlv for multi queue rx support Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 23/31] iwlwifi: treat iwl_parse_nvm_data() MAC addr as little endian Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 24/31] iwlwifi: mvm: Remove bf_vif from iwl_power_vifs Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 25/31] iwlwifi: mvm: Remove iwl_mvm_update_beacon_abort Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 26/31] iwlwifi: mvm: add new ADD_STA command version Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 27/31] iwlwifi: mvm: rs: fix TPC action decision algorithm Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 28/31] iwlwifi: mvm: support rss queues configuration command Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 29/31] iwlwifi: pcie: enable multi-queue rx path Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 30/31] iwlwifi: pcie: update iwl_mpdu_desc fields Emmanuel Grumbach
2016-01-31 11:06 ` [PATCH 31/31] iwlwifi: mvm: allow to disable beacon filtering for AP/GO interface Emmanuel Grumbach
2016-02-06 11:06 ` pull request: iwlwifi-next 2016-01-31 Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454238386-27032-7-git-send-email-emmanuel.grumbach@intel.com \
--to=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).