From: Joe Perches <joe@perches.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/5] ath10k: fix checkpatch warnings related to spaces
Date: Thu, 14 Apr 2016 00:47:08 -0700 [thread overview]
Message-ID: <1460620028.19090.12.camel@perches.com> (raw)
In-Reply-To: <20160413111320.18823.25021.stgit@potku.adurom.net>
On Wed, 2016-04-13 at 14:13 +0300, Kalle Valo wrote:
> Fix checkpatch warnings about use of spaces with operators:
> spaces preferred around that '*' (ctx:VxV)
> This has been recently added to checkpatch.
Trivia: That's not a particularly recent change.
> diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
[]
> @@ -5342,7 +5342,7 @@ enum wmi_sta_ps_param_pspoll_count {
> #define WMI_UAPSD_AC_TYPE_TRIG 1
>
> #define WMI_UAPSD_AC_BIT_MASK(ac, type) \
> - ((type == WMI_UAPSD_AC_TYPE_DELI) ? (1<<(ac<<1)) : (1<<((ac<<1)+1)))
> + ((type == WMI_UAPSD_AC_TYPE_DELI) ? (1 << (ac << 1)) : (1 << ((ac << 1) + 1)))
There are a bunch of unnecessary parentheses here.
This could also use the BIT macro:
#define WMI_UAPSD_AC_BIT_MASK(ac, type) \
(type == WMI_UAPSD_AC_TYPE_DELI ? BIT(ac << 1) : BIT((ac << 1) + 1))
next prev parent reply other threads:[~2016-04-14 7:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 11:13 [PATCH v2 0/5] ath10k: fix recent checkpatch warnings Kalle Valo
2016-04-13 11:13 ` [PATCH v2 1/5] ath10k: fix checkpatch warnings related to spaces Kalle Valo
2016-04-14 7:47 ` Joe Perches [this message]
2016-04-13 11:13 ` [PATCH v2 2/5] ath10k: prefer kernel type 'u64' over 'u_int64_t' Kalle Valo
2016-04-13 11:13 ` [PATCH v2 3/5] ath10k: prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp() Kalle Valo
2016-04-13 11:14 ` [PATCH v2 4/5] ath10k: prefer ether_addr_copy() over memcpy() Kalle Valo
2016-04-13 11:14 ` [PATCH v2 5/5] ath10k: fix parenthesis alignment Kalle Valo
2016-04-19 15:44 ` [PATCH v2 0/5] ath10k: fix recent checkpatch warnings Valo, Kalle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460620028.19090.12.camel@perches.com \
--to=joe@perches.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).