From: Maya Erez <qca_merez@qca.qualcomm.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Maya Erez <qca_merez@qca.qualcomm.com>,
linux-wireless@vger.kernel.org, wil6210@qca.qualcomm.com
Subject: [PATCH 2/6] wil6210: guarantee safe access to rx descriptors shared memory
Date: Mon, 16 May 2016 22:23:31 +0300 [thread overview]
Message-ID: <1463426615-15523-3-git-send-email-qca_merez@qca.qualcomm.com> (raw)
In-Reply-To: <1463426615-15523-1-git-send-email-qca_merez@qca.qualcomm.com>
add memory barrier after allocating new rx descriptors, before
updating the hwtail.
This will guarantee that all writes to descriptors (shared memory)
are done before committing them to HW.
Signed-off-by: Maya Erez <qca_merez@qca.qualcomm.com>
---
drivers/net/wireless/ath/wil6210/txrx.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c
index fa6ea24..3909af1 100644
--- a/drivers/net/wireless/ath/wil6210/txrx.c
+++ b/drivers/net/wireless/ath/wil6210/txrx.c
@@ -544,6 +544,12 @@ static int wil_rx_refill(struct wil6210_priv *wil, int count)
break;
}
}
+
+ /* make sure all writes to descriptors (shared memory) are done before
+ * committing them to HW
+ */
+ wmb();
+
wil_w(wil, v->hwtail, v->swtail);
return rc;
--
1.8.5.2
next prev parent reply other threads:[~2016-05-16 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 19:23 [PATCH 0/6] wil6210 patches Maya Erez
2016-05-16 19:23 ` [PATCH 1/6] wil6210: fix race conditions between TX send and completion Maya Erez
2016-05-28 8:19 ` [1/6] " Kalle Valo
2016-05-16 19:23 ` Maya Erez [this message]
2016-05-16 19:23 ` [PATCH 3/6] wil6210: protect wil_vring_fini_tx in parallel to tx completions Maya Erez
2016-05-16 19:23 ` [PATCH 4/6] wil6210: fix dma mapping error cleanup in __wil_tx_vring_tso Maya Erez
2016-05-16 19:23 ` [PATCH 5/6] wil6210: add pm_notify handling Maya Erez
2016-05-16 19:23 ` [PATCH 6/6] wil6210: align wil log functions to wil_dbg_ratelimited implementation Maya Erez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463426615-15523-3-git-send-email-qca_merez@qca.qualcomm.com \
--to=qca_merez@qca.qualcomm.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).