From: Johannes Berg <johannes@sipsolutions.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
Thomas Graf <tgraf@suug.ch>,
tom@herbertland.com, Ben Greear <greearb@candelatech.com>
Subject: Re: [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects
Date: Mon, 19 Sep 2016 11:50:34 +0200 [thread overview]
Message-ID: <1474278634.4469.25.camel@sipsolutions.net> (raw)
In-Reply-To: <20160919093434.GA12378@gondor.apana.org.au> (sfid-20160919_113440_719977_971CE718)
On Mon, 2016-09-19 at 17:34 +0800, Herbert Xu wrote:
> On Mon, Sep 19, 2016 at 11:27:24AM +0200, Johannes Berg wrote:
> >
> >
> > I have a feeling there's a bug with ht->nelems, since the crash is
> > always in the grow worker, but I haven't quite put my finger on it
> > yet.
>
> Can you show me a stack trace?
>
The stack trace is useless, but my other annotation showed that the
table's nelems *underflowed* to -1, so now the worker will continue to
try to grow it forever.
johannes
next prev parent reply other threads:[~2016-09-19 9:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 7:18 Buggy rhashtable walking Herbert Xu
2016-08-04 7:45 ` Herbert Xu
2016-08-05 6:16 ` Johannes Berg
2016-08-05 10:48 ` Herbert Xu
2016-08-05 10:50 ` Johannes Berg
2016-08-05 11:46 ` Ben Greear
2016-08-08 15:26 ` Herbert Xu
2016-09-18 13:50 ` [PATCH 0/2] rhashtable: rhashtable with duplicate objects Herbert Xu
2016-09-18 13:53 ` [PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-18 13:54 ` [PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-19 8:20 ` [PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
2016-09-19 8:25 ` Johannes Berg
2016-09-19 8:35 ` Herbert Xu
2016-09-19 8:58 ` Johannes Berg
2016-09-19 8:40 ` [v2 PATCH " Herbert Xu
2016-09-19 8:42 ` [v2 PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-19 8:42 ` [v2 PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-19 9:15 ` [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
2016-09-19 9:17 ` Herbert Xu
2016-09-19 9:27 ` Johannes Berg
2016-09-19 9:31 ` Johannes Berg
2016-09-19 9:34 ` Herbert Xu
2016-09-19 9:38 ` Johannes Berg
2016-09-19 9:50 ` Johannes Berg [this message]
2016-09-19 9:54 ` Johannes Berg
2016-09-19 10:02 ` Johannes Berg
2016-09-19 10:04 ` Johannes Berg
2016-09-19 10:10 ` Johannes Berg
2016-09-19 10:48 ` Herbert Xu
2016-09-19 10:58 ` Johannes Berg
2016-09-19 10:58 ` [v3 " Herbert Xu
2016-09-19 11:00 ` [v3 PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-19 21:16 ` Thomas Graf
2016-09-20 1:52 ` Herbert Xu
2016-09-19 11:00 ` [v3 PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-19 11:03 ` [v3 PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
2016-09-19 11:32 ` Johannes Berg
2016-09-20 8:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474278634.4469.25.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).