linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>, kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
	Yan-Hsuan Chuang <yhchuang@realtek.com>,
	Birming Chiu <birming@realtek.com>, Shaofu <shaofu@realtek.com>,
	Steven Ting <steventing@realtek.com>
Subject: Re: [PATCH 10/10] rtlwifi: btcoex: Use seq_file to dump btcoex status
Date: Sat, 24 Jun 2017 05:01:16 -0700	[thread overview]
Message-ID: <1498305676.24295.27.camel@perches.com> (raw)
In-Reply-To: <20170624015309.28099-11-Larry.Finger@lwfinger.net>

On Fri, 2017-06-23 at 20:53 -0500, Larry Finger wrote:
> From: Ping-Ke Shih <pkshih@realtek.com>
> 
> If we use seq_file to dump status, then we can use 'cat' to access
> debugfs.  Other related changes are
> 1. implement btc_disp_dbg_msg() to access btcoex's common status.
> 2. remove obsolete field bt_exist
[]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c
[]
> @@ -2719,75 +2719,64 @@ void ex_btc8192e2ant_display_coex_info(struct btc_coexist *btcoexist)
>  	u8 wifi_dot11_chnl, wifi_hs_chnl;
>  	u32 fw_ver = 0, bt_patch_ver = 0;
>  
> -	RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
> -		 "\r\n ============[BT Coexist info]============");
> +	seq_puts(m, "\r\n ============[BT Coexist info]============");
>  
>  	if (btcoexist->manual_control) {
> -		RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
> -			 "\r\n ===========[Under Manual Control]===========");
> -		RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
> -			 "\r\n ==========================================");
> -	}
> -
> -	if (!board_info->bt_exist) {
> -		RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG, "\r\n BT not exists !!!");
> -		return;
> +		seq_puts(m, "\r\n ===========[Under Manual Control]===========");
> +		seq_puts(m, "\r\n ==========================================");

All the \r uses should probably be removed.

>  	}
>  
> -	RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
> -		 "\r\n %-35s = %d/ %d ", "Ant PG number/ Ant mechanism:",
> +	seq_printf(m, "\r\n %-35s = %d/ %d ", "Ant PG number/ Ant mechanism:",
>  		   board_info->pg_ant_num, board_info->btdm_ant_num);

etc...

      reply	other threads:[~2017-06-24 12:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-24  1:52 [PATCH 00/10] Set 3 of changes related to updates of btcoexist Larry Finger
2017-06-24  1:53 ` [PATCH 01/10] rtlwifi: Fill in_4way field by driver Larry Finger
2017-06-24  1:53 ` [PATCH 02/10] rtlwifi: Add BT_MP_INFO to c2h handler Larry Finger
2017-06-24  1:53 ` [PATCH 03/10] rtlwifi: Add board type for 8723be and 8192ee Larry Finger
2017-06-24  1:53 ` [PATCH 04/10] rtlwifi: add amplifier type for 8812ae Larry Finger
2017-06-24  1:53 ` [PATCH 05/10] rtlwifi: Update 8723be new phy parameters and its parser Larry Finger
2017-06-24  1:53 ` [PATCH 06/10] rtlwifi: Rename rtl_desc92_rate to rtl_desc_rate Larry Finger
2017-06-24  1:53 ` [PATCH 07/10] rtlwifi: Uses addr1 instead DA to determine broadcast and multicast addr Larry Finger
2017-06-24  1:53 ` [PATCH 08/10] rtlwifi: move IS_HARDWARE_TYPE_xxx checker to wifi.h Larry Finger
2017-06-24  1:53 ` [PATCH 09/10] rtlwifi: use debugfs to debug Larry Finger
2017-06-24  1:53 ` [PATCH 10/10] rtlwifi: btcoex: Use seq_file to dump btcoex status Larry Finger
2017-06-24 12:01   ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498305676.24295.27.camel@perches.com \
    --to=joe@perches.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=birming@realtek.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=shaofu@realtek.com \
    --cc=steventing@realtek.com \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).