linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 00/10] Constify attribute_group structures
@ 2017-07-11  7:31 Arvind Yadav
  2017-07-11  7:31 ` [PATCH v2 04/10] wireless: ipw2200: constify " Arvind Yadav
  2017-07-11  7:31 ` [PATCH v2 05/10] wireless: ipw2100: " Arvind Yadav
  0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-07-11  7:31 UTC (permalink / raw)
  To: stas.yakovlev, kvalo; +Cc: netdev, linux-kernel, linux-wireless

attribute_groups are not supposed to change at runtime. So mark the
non-const structs as const.

Arvind Yadav (10):
  [PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures.
  [PATCH v2 02/10] net: can: at91_can: constify attribute_group structures.
  [PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures.
  [PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures.
  [PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures.
  [PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures.
  [PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures.
  [PATCH v2 08/10] arcnet: com20020-pci: constify attribute_group structures.
  [PATCH v2 09/10] net: bonding: constify attribute_group structures.
  [PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures.

 drivers/net/arcnet/com20020-pci.c               | 2 +-
 drivers/net/bonding/bond_sysfs.c                | 2 +-
 drivers/net/can/at91_can.c                      | 2 +-
 drivers/net/can/janz-ican3.c                    | 2 +-
 drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 8 ++++++--
 drivers/net/usb/cdc_ncm.c                       | 2 +-
 drivers/net/wireless/intel/ipw2x00/ipw2100.c    | 2 +-
 drivers/net/wireless/intel/ipw2x00/ipw2200.c    | 2 +-
 drivers/net/wireless/intel/iwlegacy/3945-mac.c  | 2 +-
 drivers/net/wireless/intel/iwlegacy/4965-mac.c  | 2 +-
 10 files changed, 15 insertions(+), 11 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures.
  2017-07-11  7:31 [PATCH v2 00/10] Constify attribute_group structures Arvind Yadav
@ 2017-07-11  7:31 ` Arvind Yadav
  2017-07-11  7:31 ` [PATCH v2 05/10] wireless: ipw2100: " Arvind Yadav
  1 sibling, 0 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-07-11  7:31 UTC (permalink / raw)
  To: stas.yakovlev, kvalo; +Cc: netdev, linux-kernel, linux-wireless

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
              Added cover later.

 drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
index 9368abd..c311b1a 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
@@ -11500,7 +11500,7 @@ static int ipw_wdev_init(struct net_device *dev)
 	NULL
 };
 
-static struct attribute_group ipw_attribute_group = {
+static const struct attribute_group ipw_attribute_group = {
 	.name = NULL,		/* put in device directory */
 	.attrs = ipw_sysfs_entries,
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures.
  2017-07-11  7:31 [PATCH v2 00/10] Constify attribute_group structures Arvind Yadav
  2017-07-11  7:31 ` [PATCH v2 04/10] wireless: ipw2200: constify " Arvind Yadav
@ 2017-07-11  7:31 ` Arvind Yadav
  1 sibling, 0 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-07-11  7:31 UTC (permalink / raw)
  To: stas.yakovlev, kvalo; +Cc: netdev, linux-kernel, linux-wireless

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
              Added cover later.

 drivers/net/wireless/intel/ipw2x00/ipw2100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
index aaaca4d..ccbe745 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
@@ -4324,7 +4324,7 @@ static ssize_t store_rf_kill(struct device *d, struct device_attribute *attr,
 	NULL,
 };
 
-static struct attribute_group ipw2100_attribute_group = {
+static const struct attribute_group ipw2100_attribute_group = {
 	.attrs = ipw2100_sysfs_entries,
 };
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-11  7:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-11  7:31 [PATCH v2 00/10] Constify attribute_group structures Arvind Yadav
2017-07-11  7:31 ` [PATCH v2 04/10] wireless: ipw2200: constify " Arvind Yadav
2017-07-11  7:31 ` [PATCH v2 05/10] wireless: ipw2100: " Arvind Yadav

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).