linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: pkshih@realtek.com, kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 02/15] rtlwifi: remove redundant statement found by static checker
Date: Fri, 2 Mar 2018 16:07:32 -0600	[thread overview]
Message-ID: <14a0642d-b8d5-2111-c937-96c22987ec49@lwfinger.net> (raw)
In-Reply-To: <20180228030718.19510-3-pkshih@realtek.com>

On 02/27/2018 09:07 PM, pkshih@realtek.com wrote:
> From: Ping-Ke Shih <pkshih@realtek.com>
> 
> smatch reports "rtl_is_special_data() warn: inconsistent indenting", but
> it is an obvious redundant statement so remove it.
> 
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

> ---
>   drivers/net/wireless/realtek/rtlwifi/base.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index 6db3389e2ced..762a29cdf7ad 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -1549,7 +1549,6 @@ u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx,
>   		/* EAPOL is seens as in-4way */
>   		rtlpriv->btcoexist.btc_info.in_4way = true;
>   		rtlpriv->btcoexist.btc_info.in_4way_ts = jiffies;
> -	rtlpriv->btcoexist.btc_info.in_4way_ts = jiffies;
>   
>   		RT_TRACE(rtlpriv, (COMP_SEND | COMP_RECV), DBG_DMESG,
>   			 "802.1X %s EAPOL pkt!!\n", (is_tx) ? "Tx" : "Rx");
> 

  reply	other threads:[~2018-03-02 22:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28  3:07 [PATCH 00/15] rtlwifi: Add 8822b 1ant/2ant btcoex files pkshih
2018-02-28  3:07 ` [PATCH 01/15] rtlwifi: Add modifier static to functions reported by sparse pkshih
2018-03-02 22:06   ` Larry Finger
2018-02-28  3:07 ` [PATCH 02/15] rtlwifi: remove redundant statement found by static checker pkshih
2018-03-02 22:07   ` Larry Finger [this message]
2018-02-28  3:07 ` [PATCH 03/15] rtlwifi: btcoex: Add enum DM_INFO for btcoex to query dm's counters pkshih
2018-03-02 22:19   ` Larry Finger
2018-03-03  5:12     ` Pkshih
2018-02-28  3:07 ` [PATCH 04/15] rtlwifi: btcoex: Add customer_id to do special deal to oem vendor pkshih
2018-03-02 22:12   ` Larry Finger
2018-02-28  3:07 ` [PATCH 05/15] rtlwifi: btcoex: Get status of multichannel concurrence pkshih
2018-03-02 22:20   ` Larry Finger
2018-02-28  3:07 ` [PATCH 06/15] rtlwifi: btcoex: Add rate table for the use of btcoex pkshih
2018-02-28  3:07 ` [PATCH 07/15] rtlwifi: btcoex: Add interaction with phydm pkshih
2018-02-28  3:07 ` [PATCH 08/15] rtlwifi: btcoex: Add pre- and post- normal LPS function pkshih
2018-02-28  3:07 ` [PATCH 09/15] rtlwifi: btcoex: add assoc type v2 to connection notify pkshih
2018-02-28  3:07 ` [PATCH 10/15] rtlwifi: btcoex: new definitions introduced by 8822be pkshih
2018-02-28  3:07 ` [PATCH 11/15] rtlwifi: btcoex: Add new but dummy definitions introduced by 8822b pkshih
2018-02-28  3:07 ` [PATCH 12/15] rtlwifi: btcoex: Add 8822b 1ant/2ant coex files pkshih
2018-03-27  7:32   ` Kalle Valo
2018-03-27  9:32     ` Pkshih
2018-03-27 14:17       ` Kalle Valo
2018-02-28  3:07 ` [PATCH 13/15] rtlwifi: btcoex: Add 8822b header files to precomp.h pkshih
2018-02-28  3:07 ` [PATCH 14/15] rtlwifi: btcoex: Add 8822b to Makefile pkshih
2018-02-28  3:07 ` [PATCH 15/15] rtlwifi: btcoex: Add 8822b routine to btc interfaces pkshih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14a0642d-b8d5-2111-c937-96c22987ec49@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).