* [PATCH v3 04/10] wireless: ipw2200: constify attribute_group structures.
@ 2017-07-18 9:44 Arvind Yadav
2017-07-18 9:45 ` [PATCH v3 05/10] wireless: ipw2100: " Arvind Yadav
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Arvind Yadav @ 2017-07-18 9:44 UTC (permalink / raw)
To: davem, stas.yakovlev, kvalo, sgruszka
Cc: netdev, linux-kernel, linux-wireless
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
Added cover later.
Changes in v3:
net-next was closed. Now resubmitting it.
drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
index 9368abd..c311b1a 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
@@ -11500,7 +11500,7 @@ static int ipw_wdev_init(struct net_device *dev)
NULL
};
-static struct attribute_group ipw_attribute_group = {
+static const struct attribute_group ipw_attribute_group = {
.name = NULL, /* put in device directory */
.attrs = ipw_sysfs_entries,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 05/10] wireless: ipw2100: constify attribute_group structures.
2017-07-18 9:44 [PATCH v3 04/10] wireless: ipw2200: constify attribute_group structures Arvind Yadav
@ 2017-07-18 9:45 ` Arvind Yadav
2017-07-18 9:45 ` [PATCH v3 06/10] wireless: iwlegacy: " Arvind Yadav
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Arvind Yadav @ 2017-07-18 9:45 UTC (permalink / raw)
To: davem, stas.yakovlev, kvalo, sgruszka
Cc: netdev, linux-kernel, linux-wireless
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
Added cover later.
Changes in v3:
net-next was closed. Now resubmitting it.
drivers/net/wireless/intel/ipw2x00/ipw2100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
index aaaca4d..ccbe745 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
@@ -4324,7 +4324,7 @@ static ssize_t store_rf_kill(struct device *d, struct device_attribute *attr,
NULL,
};
-static struct attribute_group ipw2100_attribute_group = {
+static const struct attribute_group ipw2100_attribute_group = {
.attrs = ipw2100_sysfs_entries,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 06/10] wireless: iwlegacy: constify attribute_group structures.
2017-07-18 9:44 [PATCH v3 04/10] wireless: ipw2200: constify attribute_group structures Arvind Yadav
2017-07-18 9:45 ` [PATCH v3 05/10] wireless: ipw2100: " Arvind Yadav
@ 2017-07-18 9:45 ` Arvind Yadav
2017-07-18 9:45 ` [PATCH v3 07/10] wireless: iwlegacy: Constify " Arvind Yadav
2017-07-28 15:06 ` [v3,04/10] ipw2200: constify " Kalle Valo
3 siblings, 0 replies; 7+ messages in thread
From: Arvind Yadav @ 2017-07-18 9:45 UTC (permalink / raw)
To: davem, stas.yakovlev, kvalo, sgruszka
Cc: netdev, linux-kernel, linux-wireless
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
Added cover later.
Changes in v3:
net-next was closed. Now resubmitting it.
drivers/net/wireless/intel/iwlegacy/3945-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/3945-mac.c b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
index 38bf403..329f3a6 100644
--- a/drivers/net/wireless/intel/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
@@ -3464,7 +3464,7 @@ static DEVICE_ATTR(antenna, S_IWUSR | S_IRUGO, il3945_show_antenna,
NULL
};
-static struct attribute_group il3945_attribute_group = {
+static const struct attribute_group il3945_attribute_group = {
.name = NULL, /* put in device directory */
.attrs = il3945_sysfs_entries,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 07/10] wireless: iwlegacy: Constify attribute_group structures.
2017-07-18 9:44 [PATCH v3 04/10] wireless: ipw2200: constify attribute_group structures Arvind Yadav
2017-07-18 9:45 ` [PATCH v3 05/10] wireless: ipw2100: " Arvind Yadav
2017-07-18 9:45 ` [PATCH v3 06/10] wireless: iwlegacy: " Arvind Yadav
@ 2017-07-18 9:45 ` Arvind Yadav
2017-07-28 15:06 ` [v3,04/10] ipw2200: constify " Kalle Valo
3 siblings, 0 replies; 7+ messages in thread
From: Arvind Yadav @ 2017-07-18 9:45 UTC (permalink / raw)
To: davem, stas.yakovlev, kvalo, sgruszka
Cc: netdev, linux-kernel, linux-wireless
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
Added cover later.
Changes in v3:
net-next was closed. Now resubmitting it.
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
index 5b51fba..de9b652 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
@@ -4654,7 +4654,7 @@ static DEVICE_ATTR(tx_power, S_IWUSR | S_IRUGO, il4965_show_tx_power,
NULL
};
-static struct attribute_group il_attribute_group = {
+static const struct attribute_group il_attribute_group = {
.name = NULL, /* put in device directory */
.attrs = il_sysfs_entries,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [v3,04/10] ipw2200: constify attribute_group structures
2017-07-18 9:44 [PATCH v3 04/10] wireless: ipw2200: constify attribute_group structures Arvind Yadav
` (2 preceding siblings ...)
2017-07-18 9:45 ` [PATCH v3 07/10] wireless: iwlegacy: Constify " Arvind Yadav
@ 2017-07-28 15:06 ` Kalle Valo
2017-07-28 15:08 ` Kalle Valo
3 siblings, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2017-07-28 15:06 UTC (permalink / raw)
To: Arvind Yadav
Cc: davem, stas.yakovlev, sgruszka, netdev, linux-kernel, linux-wireless
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
4 patches applied to wireless-drivers-next.git, thanks.
17830147c40a mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient"
185ffc194800 ipw2100: don't return positive values to PCI probe on error
af643fe9bbe0 zd1211rw: fix spelling mistake 'hybernate' -> 'hibernate'
e66d70b789d1 brcmfmac: constify pci_device_id
--
https://patchwork.kernel.org/patch/9847373/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [v3,04/10] ipw2200: constify attribute_group structures
2017-07-28 15:06 ` [v3,04/10] ipw2200: constify " Kalle Valo
@ 2017-07-28 15:08 ` Kalle Valo
2017-07-28 16:54 ` Kalle Valo
0 siblings, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2017-07-28 15:08 UTC (permalink / raw)
To: Arvind Yadav
Cc: davem, stas.yakovlev, sgruszka, netdev, linux-kernel, linux-wireless
Kalle Valo <kvalo@codeaurora.org> writes:
> Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
>
>> attribute_group are not supposed to change at runtime. All functions
>> working with attribute_group provided by <linux/sysfs.h> work
>> with const attribute_group. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> 4 patches applied to wireless-drivers-next.git, thanks.
>
> 17830147c40a mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient"
> 185ffc194800 ipw2100: don't return positive values to PCI probe on error
> af643fe9bbe0 zd1211rw: fix spelling mistake 'hybernate' -> 'hibernate'
> e66d70b789d1 brcmfmac: constify pci_device_id
Please ignore this mail, I have a bug in my patchwork script.
--
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [v3,04/10] ipw2200: constify attribute_group structures
2017-07-28 15:08 ` Kalle Valo
@ 2017-07-28 16:54 ` Kalle Valo
0 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2017-07-28 16:54 UTC (permalink / raw)
To: Arvind Yadav
Cc: davem, stas.yakovlev, sgruszka, netdev, linux-kernel, linux-wireless
Kalle Valo <kvalo@codeaurora.org> writes:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
>>
>>> attribute_group are not supposed to change at runtime. All functions
>>> working with attribute_group provided by <linux/sysfs.h> work
>>> with const attribute_group. So mark the non-const structs as const.
>>>
>>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>>
>> 4 patches applied to wireless-drivers-next.git, thanks.
>>
>> 17830147c40a mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient"
>> 185ffc194800 ipw2100: don't return positive values to PCI probe on error
>> af643fe9bbe0 zd1211rw: fix spelling mistake 'hybernate' -> 'hibernate'
>> e66d70b789d1 brcmfmac: constify pci_device_id
>
> Please ignore this mail, I have a bug in my patchwork script.
The reason was that Dave had already applied these patches but my script
failed to detect that. I need to fix my script.
--
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-28 16:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-18 9:44 [PATCH v3 04/10] wireless: ipw2200: constify attribute_group structures Arvind Yadav
2017-07-18 9:45 ` [PATCH v3 05/10] wireless: ipw2100: " Arvind Yadav
2017-07-18 9:45 ` [PATCH v3 06/10] wireless: iwlegacy: " Arvind Yadav
2017-07-18 9:45 ` [PATCH v3 07/10] wireless: iwlegacy: Constify " Arvind Yadav
2017-07-28 15:06 ` [v3,04/10] ipw2200: constify " Kalle Valo
2017-07-28 15:08 ` Kalle Valo
2017-07-28 16:54 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).