[PATCH] iwlwifi: Demote messages about fw flags size to info

[PATCH] iwlwifi: Demote messages about fw flags size to info

[João Paulo Rechi Vita]

These messages are not reporting a real error, just the fact that the
firmware knows about more flags then the driver.

Currently these messages are presented to the user during boot if there
is no bootsplash covering the console, sometimes even if the boot splash
is enabled but has not started yet by the time this message is shown.

Demoting it to the info level helps having a clean boot process.

Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
---
 drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
index 6fdb5921e17f..557acd43d705 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
@@ -487,9 +487,9 @@ static int iwl_set_ucode_api_flags(struct iwl_drv *drv, const u8 *data,
 	int i;
 
 	if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_API, 32)) {
-		IWL_ERR(drv,
-			"api flags index %d larger than supported by driver\n",
-			api_index);
+		IWL_INFO(drv,
+			 "api flags index %d larger than supported by driver\n",
+			 api_index);
 		/* don't return an error so we can load FW that has more bits */
 		return 0;
 	}
@@ -511,9 +511,9 @@ static int iwl_set_ucode_capabilities(struct iwl_drv *drv, const u8 *data,
 	int i;
 
 	if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_CAPA, 32)) {
-		IWL_ERR(drv,
-			"capa flags index %d larger than supported by driver\n",
-			api_index);
+		IWL_INFO(drv,
+			 "capa flags index %d larger than supported by driver\n",
+			 api_index);
 		/* don't return an error so we can load FW that has more bits */
 		return 0;
 	}
-- 
2.13.2

Re: [PATCH] iwlwifi: Demote messages about fw flags size to info

[Coelho, Luciano]

T24gRnJpLCAyMDE3LTA3LTIxIGF0IDA3OjUxIC0wNzAwLCBKb8OjbyBQYXVsbyBSZWNoaSBWaXRh
IHdyb3RlOg0KPiBUaGVzZSBtZXNzYWdlcyBhcmUgbm90IHJlcG9ydGluZyBhIHJlYWwgZXJyb3Is
IGp1c3QgdGhlIGZhY3QgdGhhdCB0aGUNCj4gZmlybXdhcmUga25vd3MgYWJvdXQgbW9yZSBmbGFn
cyB0aGVuIHRoZSBkcml2ZXIuDQo+IA0KPiBDdXJyZW50bHkgdGhlc2UgbWVzc2FnZXMgYXJlIHBy
ZXNlbnRlZCB0byB0aGUgdXNlciBkdXJpbmcgYm9vdCBpZiB0aGVyZQ0KPiBpcyBubyBib290c3Bs
YXNoIGNvdmVyaW5nIHRoZSBjb25zb2xlLCBzb21ldGltZXMgZXZlbiBpZiB0aGUgYm9vdCBzcGxh
c2gNCj4gaXMgZW5hYmxlZCBidXQgaGFzIG5vdCBzdGFydGVkIHlldCBieSB0aGUgdGltZSB0aGlz
IG1lc3NhZ2UgaXMgc2hvd24uDQo+IA0KPiBEZW1vdGluZyBpdCB0byB0aGUgaW5mbyBsZXZlbCBo
ZWxwcyBoYXZpbmcgYSBjbGVhbiBib290IHByb2Nlc3MuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBK
b8OjbyBQYXVsbyBSZWNoaSBWaXRhIDxqcHJ2aXRhQGVuZGxlc3NtLmNvbT4NCj4gLS0tDQoNClRo
ZSBpZGVhIHdpdGggdGhpcyBlcnJvciBpcyB0aGF0IGlmIHRoZSBmaXJtd2FyZSBpcyB0b28gbmV3
IGFuZCBpbmNsdWRlcw0KYSBUTFYgdGhhdCB3ZSBhcmUgbm90IGF3YXJlIG9mLCB0aGVyZSBjYW4g
YmUgdW5leHBlY3RlZCBpc3N1ZXMuICBGb3INCmluc3RhbmNlLCBzb21ldGltZXMgdGhlIEZXIEFQ
SSBjaGFuZ2VzIHNvbWUgb2YgaXRzIHN0cnVjdHVyZXMgYW5kIHdlIHVzZQ0KVExWcyB0byBrbm93
IHdoaWNoIG9uZSB0byB1c2UuICBJZiBhIG5ldyBzdHJ1Y3QgaXMgaW4gdXNlIGJ5IHRoZQ0KZmly
bXdhcmUgYnV0IG5vdCBieSB0aGUgZHJpdmVyLCBwcm9ibGVtcyB3aWxsIG9jY3VyLg0KDQpSZWNl
bnRseSB3ZSBhY2NpZGVudGFsbHkgb21pdHRlZCBvbmUgVExWIGZyb20gdGhlIGRyaXZlciBhbmQg
cmVsZWFzZWQgYQ0KbmV3IGZpcm13YXJlIHRoYXQgaGFkIGl0IHNldC4uLiBUaGF0J3MgdGhlIGVy
cm9yIHlvdSBhcmUgY3VycmVudGx5DQpzZWVpbmcuICBXZSBoYXZlIGEgYnVnemlsbGEgZW50cnlb
MV0gYW5kIGl0IGlzIGZpeGVkIGluIG91ciBpbnRlcm5hbA0KdHJlZS4gIFRoZSBmaXggd2lsbCBi
ZSBzZW50IHVwc3RyZWFtIGluIHRoZSBuZXh0IC1maXhlcyByb3VuZCB3ZSBzZW5kDQpvdXQuDQoN
ClRoaXMgc3BlY2lmaWMgY2FzZSBpcyBoYXJtbGVzcywgYnV0IEknZCByYXRoZXIga2VlcCB0aGlz
IG1lc3NhZ2UgYXMgYW4NCmVycm9yLCBiZWNhdXNlIGluIG90aGVyIHNpdHVhdGlvbnMgaXQgY291
bGQgbGVhZCB0byB1bmV4cGVjdGVkDQpiZWhhdmlvaXIsIHNvIEkgcHJlZmVyIHRvIGtlZXAgaXQg
dmVyeSB2aXNpYmxlLg0KDQoNClsxXSBodHRwczovL2J1Z3ppbGxhLmtlcm5lbC5vcmcvc2hvd19i
dWcuY2dpP2lkPTE5NjE5NQ0KDQotLQ0KQ2hlZXJzLA0KTHVjYS4=

Re: [PATCH] iwlwifi: Demote messages about fw flags size to info

[João Paulo Rechi Vita]

Hello Luca,

On Mon, Jul 24, 2017 at 4:01 AM, Coelho, Luciano
<luciano.coelho@intel.com> wrote:
> On Fri, 2017-07-21 at 07:51 -0700, Jo=C3=A3o Paulo Rechi Vita wrote:

(...)

>> Currently these messages are presented to the user during boot if there
>> is no bootsplash covering the console, sometimes even if the boot splash
>> is enabled but has not started yet by the time this message is shown.
>>

I should have provided another piece of information here: all of this
happens even when booting with the 'quiet' kernel parameter.

> This specific case is harmless, but I'd rather keep this message as an
> error, because in other situations it could lead to unexpected
> behavioir, so I prefer to keep it very visible.
>
>

I see your point, and I understand the purpose of these messages. I'm
wondering if perhaps having them at the warning level would give them
enough visibility, while still keeping a clean boot process to the end
user. If so, I can send an updated patch.

Thanks for your reply and for pointing to the fix for the root cause
of that message.

Cheers,

...........................................................................=
...........
Jo=C3=A3o Paulo Rechi Vita  |  +1.415.851.5778  |  Endless

Re: [PATCH] iwlwifi: Demote messages about fw flags size to info

[Luca Coelho]

Hi João Paulo,


On Tue, 2017-08-01 at 15:58 -0700, João Paulo Rechi Vita wrote:
> Hello Luca,
> 
> On Mon, Jul 24, 2017 at 4:01 AM, Coelho, Luciano
> <luciano.coelho@intel.com> wrote:
> > On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote:
> 
> (...)
> 
> > > Currently these messages are presented to the user during boot if there
> > > is no bootsplash covering the console, sometimes even if the boot splash
> > > is enabled but has not started yet by the time this message is shown.
> > > 
> 
> I should have provided another piece of information here: all of this
> happens even when booting with the 'quiet' kernel parameter.

Oh, okay, that's annoying.


> > This specific case is harmless, but I'd rather keep this message as an
> > error, because in other situations it could lead to unexpected
> > behavioir, so I prefer to keep it very visible.
> > 
> > 
> 
> I see your point, and I understand the purpose of these messages. I'm
> wondering if perhaps having them at the warning level would give them
> enough visibility, while still keeping a clean boot process to the end
> user. If so, I can send an updated patch.
> 
> Thanks for your reply and for pointing to the fix for the root cause
> of that message.

Sure, I agree it's better to make it use IWL_WARN(), which will generate
a dev_warn() instead of a dev_err().


--
Cheers,
Luca.

[PATCH v2] iwlwifi: Demote messages about fw flags size to info

[João Paulo Rechi Vita]

These messages are not reporting a real error, just the fact that the
firmware knows about more flags then the driver.

Currently these messages are presented to the user during boot if there
is no bootsplash covering the console, even when booting the kernel with
"quiet".

Demoting it to the warn level helps having a clean boot process.

Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
---

v2 changes:
 - Set to warn level instead of info

 drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
index be466a074c1d..c98a254bbd4d 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
@@ -461,9 +461,9 @@ static int iwl_set_ucode_api_flags(struct iwl_drv *drv, const u8 *data,
 	int i;
 
 	if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_API, 32)) {
-		IWL_ERR(drv,
-			"api flags index %d larger than supported by driver\n",
-			api_index);
+		IWL_WARN(drv,
+			 "api flags index %d larger than supported by driver\n",
+			 api_index);
 		/* don't return an error so we can load FW that has more bits */
 		return 0;
 	}
@@ -485,9 +485,9 @@ static int iwl_set_ucode_capabilities(struct iwl_drv *drv, const u8 *data,
 	int i;
 
 	if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_CAPA, 32)) {
-		IWL_ERR(drv,
-			"capa flags index %d larger than supported by driver\n",
-			api_index);
+		IWL_WARN(drv,
+			 "capa flags index %d larger than supported by driver\n",
+			 api_index);
 		/* don't return an error so we can load FW that has more bits */
 		return 0;
 	}
-- 
2.13.2

RE: [PATCH v2] iwlwifi: Demote messages about fw flags size to info

[David Laight]

RnJvbTogSm/Do28gUGF1bG8gUmVjaGkgVml0YQ0KPiBTZW50OiAwMyBBdWd1c3QgMjAxNyAxNToz
MA0KPiBUaGVzZSBtZXNzYWdlcyBhcmUgbm90IHJlcG9ydGluZyBhIHJlYWwgZXJyb3IsIGp1c3Qg
dGhlIGZhY3QgdGhhdCB0aGUNCj4gZmlybXdhcmUga25vd3MgYWJvdXQgbW9yZSBmbGFncyB0aGVu
IHRoZSBkcml2ZXIuDQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGhhbg0KPiAN
Cj4gQ3VycmVudGx5IHRoZXNlIG1lc3NhZ2VzIGFyZSBwcmVzZW50ZWQgdG8gdGhlIHVzZXIgZHVy
aW5nIGJvb3QgaWYgdGhlcmUNCj4gaXMgbm8gYm9vdHNwbGFzaCBjb3ZlcmluZyB0aGUgY29uc29s
ZSwgZXZlbiB3aGVuIGJvb3RpbmcgdGhlIGtlcm5lbCB3aXRoDQo+ICJxdWlldCIuDQo+IA0KPiBE
ZW1vdGluZyBpdCB0byB0aGUgd2FybiBsZXZlbCBoZWxwcyBoYXZpbmcgYSBjbGVhbiBib290IHBy
b2Nlc3MuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKb28gUGF1bG8gUmVjaGkgVml0YSA8anBydml0
YUBlbmRsZXNzbS5jb20+DQoNCglEYXZpZA0KDQo=

[PATCH v3] iwlwifi: Demote messages about fw flags size to info

[João Paulo Rechi Vita]

These messages are not reporting a real error, just the fact that the
firmware knows about more flags than the driver.

Currently these messages are presented to the user during boot if there
is no bootsplash covering the console, even when booting the kernel with
"quiet".

Demoting it to the warn level helps having a clean boot process.

Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
---

v2 changes:
 - Set to warn level instead of info

v3 changes:
 - Fix commit message typo

 drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
index be466a074c1d..c98a254bbd4d 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
@@ -461,9 +461,9 @@ static int iwl_set_ucode_api_flags(struct iwl_drv *drv, const u8 *data,
 	int i;
 
 	if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_API, 32)) {
-		IWL_ERR(drv,
-			"api flags index %d larger than supported by driver\n",
-			api_index);
+		IWL_WARN(drv,
+			 "api flags index %d larger than supported by driver\n",
+			 api_index);
 		/* don't return an error so we can load FW that has more bits */
 		return 0;
 	}
@@ -485,9 +485,9 @@ static int iwl_set_ucode_capabilities(struct iwl_drv *drv, const u8 *data,
 	int i;
 
 	if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_CAPA, 32)) {
-		IWL_ERR(drv,
-			"capa flags index %d larger than supported by driver\n",
-			api_index);
+		IWL_WARN(drv,
+			 "capa flags index %d larger than supported by driver\n",
+			 api_index);
 		/* don't return an error so we can load FW that has more bits */
 		return 0;
 	}
-- 
2.13.2

Re: [PATCH v3] iwlwifi: Demote messages about fw flags size to info

[Coelho, Luciano]

T24gVGh1LCAyMDE3LTA4LTAzIGF0IDA3OjQ3IC0wNzAwLCBKb8OjbyBQYXVsbyBSZWNoaSBWaXRh
IHdyb3RlOg0KPiBUaGVzZSBtZXNzYWdlcyBhcmUgbm90IHJlcG9ydGluZyBhIHJlYWwgZXJyb3Is
IGp1c3QgdGhlIGZhY3QgdGhhdCB0aGUNCj4gZmlybXdhcmUga25vd3MgYWJvdXQgbW9yZSBmbGFn
cyB0aGFuIHRoZSBkcml2ZXIuDQo+IA0KPiBDdXJyZW50bHkgdGhlc2UgbWVzc2FnZXMgYXJlIHBy
ZXNlbnRlZCB0byB0aGUgdXNlciBkdXJpbmcgYm9vdCBpZiB0aGVyZQ0KPiBpcyBubyBib290c3Bs
YXNoIGNvdmVyaW5nIHRoZSBjb25zb2xlLCBldmVuIHdoZW4gYm9vdGluZyB0aGUga2VybmVsIHdp
dGgNCj4gInF1aWV0Ii4NCj4gDQo+IERlbW90aW5nIGl0IHRvIHRoZSB3YXJuIGxldmVsIGhlbHBz
IGhhdmluZyBhIGNsZWFuIGJvb3QgcHJvY2Vzcy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEpvw6Nv
IFBhdWxvIFJlY2hpIFZpdGEgPGpwcnZpdGFAZW5kbGVzc20uY29tPg0KPiAtLS0NCj4gDQo+IHYy
IGNoYW5nZXM6DQo+ICAtIFNldCB0byB3YXJuIGxldmVsIGluc3RlYWQgb2YgaW5mbw0KPiANCj4g
djMgY2hhbmdlczoNCj4gIC0gRml4IGNvbW1pdCBtZXNzYWdlIHR5cG8NCg0KVGhhbmtzLCBKb8Oj
byBQYXVsbyEgSSBwdXNoZWQgdGhpcyB0byBvdXIgaW50ZXJuYWwgdHJlZSBhbmQgaXQgd2lsbA0K
ZXZlbnR1YWxseSByZWFjaCB0aGUgbWFpbmxpbmUgZm9sbG93aW5nIG91ciBub3JtYWwgdXBzdHJl
YW1pbmcgcHJvY2Vzcy4NCg0KLS0NCkNoZWVycywNCkx1Y2Eu