linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Peter Oh <peter.oh@bowerswilkins.com>, Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org,
	Haim Dreyfuss <haim.dreyfuss@intel.com>,
	Luca Coelho <luciano.coelho@intel.com>
Subject: Re: [PATCH v3 2/3] mac80211: limit wmm params to comply with ETSI requirements
Date: Thu, 29 Mar 2018 10:35:01 +0200	[thread overview]
Message-ID: <1522312501.5932.0.camel@sipsolutions.net> (raw)
In-Reply-To: <fc2a88ae-b908-028a-9e3b-1457404d2c06@bowerswilkins.com>

On Wed, 2018-03-28 at 10:29 -0700, Peter Oh wrote:
> > +	if (sdata->vif.type == NL80211_IFTYPE_AP)
> > +		wmm_ac = &rrule->wmm_rule->ap[ac];
> > +	else
> > +		wmm_ac = &rrule->wmm_rule->client[ac];
> > +	qparam->cw_min = max_t(u16, qparam->cw_min, wmm_ac->cw_min);
> > +	qparam->cw_max = max_t(u16, qparam->cw_max, wmm_ac->cw_max);
> 
> not min_t() for cw_max?

No, the regulations say you have to use a long content window, hence
limiting both min and max at the lower end (hence max_t).

johannes

  reply	other threads:[~2018-03-29  8:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 10:24 [PATCH v3 0/3] cfg80211/mac80211: ETSI requirements patches Luca Coelho
2018-03-28 10:24 ` [PATCH v3 1/3] cfg80211: read wmm rules from regulatory database Luca Coelho
2018-03-28 10:24 ` [PATCH v3 2/3] mac80211: limit wmm params to comply with ETSI requirements Luca Coelho
2018-03-28 17:29   ` Peter Oh
2018-03-29  8:35     ` Johannes Berg [this message]
2018-03-29  8:55       ` Arend van Spriel
2018-03-29  8:59         ` Johannes Berg
2018-03-29  8:52   ` Johannes Berg
2018-03-28 10:24 ` [PATCH v3 3/3] cfg80211: Add API to allow querying regdb for wmm_rule Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522312501.5932.0.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=haim.dreyfuss@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luca@coelho.fi \
    --cc=luciano.coelho@intel.com \
    --cc=peter.oh@bowerswilkins.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).