linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sushant Kumar Mishra <sushant2k1513@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
	Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>,
	Sanjay Kumar Konduri <sajay.konduri@redpinesignals.com>,
	Sushant Kumar Mishra <sushant.mishra@redpinesignals.com>
Subject: [PATCH 3/4] rsi: fix for WoWLAN wakeup in security mode.
Date: Thu,  5 Jul 2018 18:08:21 +0530	[thread overview]
Message-ID: <1530794302-8833-4-git-send-email-sushant2k1513@gmail.com> (raw)
In-Reply-To: <1530794302-8833-1-git-send-email-sushant2k1513@gmail.com>

From: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>

System is unable to wake-up through magic-packet in secured connections.
Because key descriptor is getting corrupted and firmware is unable to
decrypt the magic packet. Fixed the issue by properly preparing it
before sending it to firmware.

Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
Signed-off-by: Sushant Kumar Mishra <sushant.mishra@redpinesignals.com>
---
 drivers/net/wireless/rsi/rsi_91x_mgmt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index 8280f32..1095df7 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -746,7 +746,7 @@ int rsi_hal_load_key(struct rsi_common *common,
 			key_descriptor |= RSI_CIPHER_TKIP;
 	}
 	key_descriptor |= RSI_PROTECT_DATA_FRAMES;
-	key_descriptor |= ((key_id << RSI_KEY_ID_OFFSET) & RSI_KEY_ID_MASK);
+	key_descriptor |= (key_id << RSI_KEY_ID_OFFSET);
 
 	rsi_set_len_qno(&set_key->desc_dword0.len_qno,
 			(frame_len - FRAME_DESC_SZ), RSI_WIFI_MGMT_Q);
-- 
2.5.5

  parent reply	other threads:[~2018-07-05 12:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 12:38 [PATCH 0/4] rsi driver common fixes Sushant Kumar Mishra
2018-07-05 12:38 ` [PATCH 1/4] rsi: fix for low throughput issue Sushant Kumar Mishra
2018-07-31  7:15   ` Kalle Valo
2018-07-05 12:38 ` [PATCH 2/4] rsi: fix for 40MHZ connection issue Sushant Kumar Mishra
2018-07-05 12:38 ` Sushant Kumar Mishra [this message]
2018-07-05 12:38 ` [PATCH 4/4] rsi: optimize virtual interfaces Sushant Kumar Mishra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530794302-8833-4-git-send-email-sushant2k1513@gmail.com \
    --to=sushant2k1513@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sajay.konduri@redpinesignals.com \
    --cc=siva.rebbagondla@redpinesignals.com \
    --cc=sushant.mishra@redpinesignals.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).