From: Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "brcm80211-dev-list@broadcom.com"
<brcm80211-dev-list@broadcom.com>,
brcm80211-dev-list <brcm80211-dev-list@cypress.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <Wright.Feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
Madhan Mohan R <MadhanMohan.R@cypress.com>,
Madhan Mohan R <MadhanMohan.R@cypress.com>,
Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>
Subject: [PATCH V2 3/8] brcmfmac: set SDIO F1 MesBusyCtrl for CYW4373
Date: Mon, 12 Nov 2018 07:29:35 +0000 [thread overview]
Message-ID: <1542007730-47284-4-git-send-email-chi-hsien.lin@cypress.com> (raw)
In-Reply-To: <1542007730-47284-1-git-send-email-chi-hsien.lin@cypress.com>
From: Madhan Mohan R <MadhanMohan.R@cypress.com>
Along with F2 watermark (existing) configuration, F1 MesBusyCtrl
should be enabled & configured to avoid overflow errors.
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Madhan Mohan R <madhanmohan.r@cypress.com>
Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 +++
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 05b8cfea5f9f..b9ec40cc7d6b 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -4119,6 +4119,9 @@ static void brcmf_sdio_firmware_callback(struct device *dev, int err,
devctl |= SBSDIO_DEVCTL_F2WM_ENAB;
brcmf_sdiod_writeb(sdiod, SBSDIO_DEVICE_CTL, devctl,
&err);
+ brcmf_sdiod_writeb(sdiod, SBSDIO_FUNC1_MESBUSYCTRL,
+ CY_4373_F2_WATERMARK |
+ SBSDIO_MESBUSYCTRL_ENAB, &err);
break;
default:
brcmf_sdiod_writeb(sdiod, SBSDIO_WATERMARK,
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h
index 7faed831f07d..8aaabca1eb0e 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h
@@ -104,6 +104,9 @@
#define SBSDIO_FUNC1_RFRAMEBCHI 0x1001C
/* MesBusyCtl (rev 11) */
#define SBSDIO_FUNC1_MESBUSYCTRL 0x1001D
+/* Enable busy capability for MES access */
+#define SBSDIO_MESBUSYCTRL_ENAB 0x80
+
/* Sdio Core Rev 12 */
#define SBSDIO_FUNC1_WAKEUPCTRL 0x1001E
#define SBSDIO_FUNC1_WCTRL_ALPWAIT_MASK 0x1
--
2.1.0
next prev parent reply other threads:[~2018-11-12 7:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 7:29 [PATCH V2 0/8] brcmfmac: chip related changes Chi-Hsien Lin
2018-11-12 7:29 ` [PATCH V2 1/8] brcmfmac: add 4354 raw pcie device id Chi-Hsien Lin
2018-11-12 10:11 ` Arend van Spriel
2018-11-12 7:29 ` [PATCH V2 2/8] brcmfmac: set F2 watermark to 256 for 4373 Chi-Hsien Lin
2018-11-12 10:12 ` Arend van Spriel
2018-11-12 7:29 ` Chi-Hsien Lin [this message]
2018-11-12 9:13 ` [PATCH V2 3/8] brcmfmac: set SDIO F1 MesBusyCtrl for CYW4373 Arend van Spriel
2018-11-20 8:50 ` Madhan Mohan R
2018-11-20 9:53 ` Arend van Spriel
2018-11-12 7:29 ` [PATCH V2 4/8] brcmfmac: add support for CYW43012 SDIO chipset Chi-Hsien Lin
2018-11-12 7:29 ` [PATCH V2 5/8] brcmfmac: allow GCI core enumuration Chi-Hsien Lin
2018-11-12 10:16 ` Arend van Spriel
2018-11-12 10:24 ` Chi-Hsien Lin
2018-11-12 10:27 ` Arend van Spriel
2018-11-12 10:29 ` Chi-Hsien Lin
2018-11-12 7:29 ` [PATCH V2 6/8] brcmfmac: update 43012 F2 watermark setting to fix DMA Error during UDP RX Traffic Chi-Hsien Lin
2018-11-12 9:25 ` Arend van Spriel
2018-11-20 9:13 ` Chi-Hsien Lin
2018-11-12 7:29 ` [PATCH V2 7/8] brcmfmac: 4373 save-restore support Chi-Hsien Lin
2018-11-12 10:30 ` Arend van Spriel
2018-11-20 9:15 ` Chi-Hsien Lin
2018-11-12 7:30 ` [PATCH V2 8/8] brcmfmac: disable command decode in sdio_aos Chi-Hsien Lin
2018-11-12 10:31 ` Arend van Spriel
2018-11-12 10:33 ` Arend van Spriel
2018-11-15 8:08 ` Wright Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542007730-47284-4-git-send-email-chi-hsien.lin@cypress.com \
--to=chi-hsien.lin@cypress.com \
--cc=MadhanMohan.R@cypress.com \
--cc=Wright.Feng@cypress.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).