Re: [REGRESSION] hostapd 2.4..2.7 broken with 4.18+

[Arend van Spriel <arend.vanspriel@broadcom.com>]

On 1/17/2019 11:03 AM, Russell King - ARM Linux admin wrote:> On Wed, Jan 16, 2019 at 02:21:32PM +0100, Arend Van Spriel wrote:
>> The patch below works for me so can you provide the counters file contents
>> after hitting the issue.
> 
> Okay, with the patch fixed, it seems to have failed last night for some
> reason... I'm not sure exactly when it died, possibly about an hour
> after bringing it up.  Here's the full log.

Sorry for the somewhat late response. I wanted to discuss the log with
firmware engineer. Can you tell how many stations were connected to this
AP before and/or when it died? What does "died" mean? From the log I can
only conclude the firmware is not crashing. So I assume by "died" you
mean no data is successfully exchanged between hostapd and stations. This
is probably due to the failing send_key_to_dongle. Could you try the patch
below to be sure about the key configuration that fails.

Regards,
Arend
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index a62c48d..d43d4c0 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -460,6 +460,8 @@ static void convert_key_from_CPU(struct brcmf_wsec_key *key,
 	int err;
 	struct brcmf_wsec_key_le key_le;
 
+	brcmf_err("idx %d algo %d flags %x\n",
+		  key->index, key->algo, key->flags);
 	convert_key_from_CPU(key, &key_le);
 
 	brcmf_netdev_wait_pend8021x(ifp);
-- 
1.9.1