* [PATCH] mt76: change the retun type of mt76_dma_attach()
@ 2019-02-11 2:13 Ryder Lee
2019-02-11 8:38 ` Sergei Shtylyov
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Ryder Lee @ 2019-02-11 2:13 UTC (permalink / raw)
To: Lorenzo Bianconi, Felix Fietkau, Kalle Valo
Cc: Roy Luo, linux-wireless, linux-kernel, netdev, linux-mediatek, Ryder Lee
There is no need to retun 0 in mt76_dma_attach(), so switch it to void.
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/dma.c | 3 +--
drivers/net/wireless/mediatek/mt76/dma.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c
index e2ba263..d934d72 100644
--- a/drivers/net/wireless/mediatek/mt76/dma.c
+++ b/drivers/net/wireless/mediatek/mt76/dma.c
@@ -522,10 +522,9 @@ int mt76_dma_tx_queue_skb(struct mt76_dev *dev, struct mt76_queue *q,
.kick = mt76_dma_kick_queue,
};
-int mt76_dma_attach(struct mt76_dev *dev)
+void mt76_dma_attach(struct mt76_dev *dev)
{
dev->queue_ops = &mt76_dma_ops;
- return 0;
}
EXPORT_SYMBOL_GPL(mt76_dma_attach);
diff --git a/drivers/net/wireless/mediatek/mt76/dma.h b/drivers/net/wireless/mediatek/mt76/dma.h
index 357cc35..e3292df 100644
--- a/drivers/net/wireless/mediatek/mt76/dma.h
+++ b/drivers/net/wireless/mediatek/mt76/dma.h
@@ -54,7 +54,7 @@ enum mt76_mcu_evt_type {
EVT_EVENT_DFS_DETECT_RSP,
};
-int mt76_dma_attach(struct mt76_dev *dev);
+void mt76_dma_attach(struct mt76_dev *dev);
void mt76_dma_cleanup(struct mt76_dev *dev);
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] mt76: change the retun type of mt76_dma_attach()
2019-02-11 2:13 [PATCH] mt76: change the retun type of mt76_dma_attach() Ryder Lee
@ 2019-02-11 8:38 ` Sergei Shtylyov
2019-02-11 8:48 ` Ryder Lee
2019-02-11 8:48 ` [Resend PATCH] mt76: change the return " Ryder Lee
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2019-02-11 8:38 UTC (permalink / raw)
To: Ryder Lee, Lorenzo Bianconi, Felix Fietkau, Kalle Valo
Cc: Roy Luo, linux-wireless, linux-kernel, netdev, linux-mediatek
Hello!
On 11.02.2019 5:13, Ryder Lee wrote:
> There is no need to retun 0 in mt76_dma_attach(), so switch it to void.
^ r missing :-)
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mt76: change the retun type of mt76_dma_attach()
2019-02-11 8:38 ` Sergei Shtylyov
@ 2019-02-11 8:48 ` Ryder Lee
0 siblings, 0 replies; 6+ messages in thread
From: Ryder Lee @ 2019-02-11 8:48 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Lorenzo Bianconi, Felix Fietkau, Kalle Valo, netdev,
linux-mediatek, linux-wireless, Roy Luo, linux-kernel
On Mon, 2019-02-11 at 11:38 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 11.02.2019 5:13, Ryder Lee wrote:
>
> > There is no need to retun 0 in mt76_dma_attach(), so switch it to void.
> ^ r missing :-)
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> [...]
>
> MBR, Sergei
>
I will resend a new one.
Thanks
Ryder
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Resend PATCH] mt76: change the return type of mt76_dma_attach()
2019-02-11 2:13 [PATCH] mt76: change the retun type of mt76_dma_attach() Ryder Lee
2019-02-11 8:38 ` Sergei Shtylyov
@ 2019-02-11 8:48 ` Ryder Lee
2019-02-11 9:19 ` Kalle Valo
2019-02-11 19:00 ` [PATCH] mt76: change the retun " Felix Fietkau
3 siblings, 0 replies; 6+ messages in thread
From: Ryder Lee @ 2019-02-11 8:48 UTC (permalink / raw)
To: Lorenzo Bianconi, Felix Fietkau, Kalle Valo
Cc: Roy Luo, linux-wireless, linux-kernel, netdev, linux-mediatek, Ryder Lee
There is no need to return 0 in mt76_dma_attach(), so switch it to void.
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/dma.c | 3 +--
drivers/net/wireless/mediatek/mt76/dma.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c
index e2ba263..d934d72 100644
--- a/drivers/net/wireless/mediatek/mt76/dma.c
+++ b/drivers/net/wireless/mediatek/mt76/dma.c
@@ -522,10 +522,9 @@ int mt76_dma_tx_queue_skb(struct mt76_dev *dev, struct mt76_queue *q,
.kick = mt76_dma_kick_queue,
};
-int mt76_dma_attach(struct mt76_dev *dev)
+void mt76_dma_attach(struct mt76_dev *dev)
{
dev->queue_ops = &mt76_dma_ops;
- return 0;
}
EXPORT_SYMBOL_GPL(mt76_dma_attach);
diff --git a/drivers/net/wireless/mediatek/mt76/dma.h b/drivers/net/wireless/mediatek/mt76/dma.h
index 357cc35..e3292df 100644
--- a/drivers/net/wireless/mediatek/mt76/dma.h
+++ b/drivers/net/wireless/mediatek/mt76/dma.h
@@ -54,7 +54,7 @@ enum mt76_mcu_evt_type {
EVT_EVENT_DFS_DETECT_RSP,
};
-int mt76_dma_attach(struct mt76_dev *dev);
+void mt76_dma_attach(struct mt76_dev *dev);
void mt76_dma_cleanup(struct mt76_dev *dev);
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Resend PATCH] mt76: change the return type of mt76_dma_attach()
2019-02-11 2:13 [PATCH] mt76: change the retun type of mt76_dma_attach() Ryder Lee
2019-02-11 8:38 ` Sergei Shtylyov
2019-02-11 8:48 ` [Resend PATCH] mt76: change the return " Ryder Lee
@ 2019-02-11 9:19 ` Kalle Valo
2019-02-11 19:00 ` [PATCH] mt76: change the retun " Felix Fietkau
3 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-02-11 9:19 UTC (permalink / raw)
To: Ryder Lee
Cc: Lorenzo Bianconi, Felix Fietkau, Roy Luo, linux-wireless,
linux-kernel, netdev, linux-mediatek
Ryder Lee <ryder.lee@mediatek.com> writes:
> There is no need to return 0 in mt76_dma_attach(), so switch it to void.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
When you send a new version mark it as v2:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
And add a changelog:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
No need to resend because of this, but please do remember this in the
future.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mt76: change the retun type of mt76_dma_attach()
2019-02-11 2:13 [PATCH] mt76: change the retun type of mt76_dma_attach() Ryder Lee
` (2 preceding siblings ...)
2019-02-11 9:19 ` Kalle Valo
@ 2019-02-11 19:00 ` Felix Fietkau
3 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2019-02-11 19:00 UTC (permalink / raw)
To: Ryder Lee, Lorenzo Bianconi, Kalle Valo
Cc: Roy Luo, linux-wireless, linux-kernel, netdev, linux-mediatek
On 2019-02-11 03:13, Ryder Lee wrote:
> There is no need to retun 0 in mt76_dma_attach(), so switch it to void.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Applied, thanks.
- Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-11 19:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 2:13 [PATCH] mt76: change the retun type of mt76_dma_attach() Ryder Lee
2019-02-11 8:38 ` Sergei Shtylyov
2019-02-11 8:48 ` Ryder Lee
2019-02-11 8:48 ` [Resend PATCH] mt76: change the return " Ryder Lee
2019-02-11 9:19 ` Kalle Valo
2019-02-11 19:00 ` [PATCH] mt76: change the retun " Felix Fietkau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).