From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09038C76186 for ; Wed, 24 Jul 2019 03:15:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE8132253D for ; Wed, 24 Jul 2019 03:15:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726437AbfGXDPx (ORCPT ); Tue, 23 Jul 2019 23:15:53 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:47175 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725848AbfGXDPx (ORCPT ); Tue, 23 Jul 2019 23:15:53 -0400 X-UUID: c2537188f1c24a84987cc8212d93d3b3-20190724 X-UUID: c2537188f1c24a84987cc8212d93d3b3-20190724 Received: from mtkmrs01.mediatek.inc [(172.21.131.159)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1780678813; Wed, 24 Jul 2019 11:15:47 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 24 Jul 2019 11:15:46 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 24 Jul 2019 11:15:46 +0800 Message-ID: <1563938146.8010.4.camel@mtkswgap22> Subject: Re: [PATCH] mt76: switch to SPDX tag instead of verbose boilerplate text From: Ryder Lee To: Roy Luo CC: Felix Fietkau , Lorenzo Bianconi , YF Luo , Yiwei Chung , Sean Wang , , , Date: Wed, 24 Jul 2019 11:15:46 +0800 In-Reply-To: References: <6f6d5cf551a0b0d0dd1b902aca2c5417b7f98da7.1563864007.git.ryder.lee@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2019-07-24 at 11:03 +0800, Roy Luo wrote: > Hi Ryder, > > Please follow the convention, some of your header files use //. > > C source: // SPDX-License-Identifier: > C header: /* SPDX-License-Identifier: */ > > Regards, > Cheng-Hao (Roy) Luo I also found that - copy paste mistake. And I will fold this one into 'fix many checkpatch.pl warnings' series then send v1. Ryder > On Tue, Jul 23, 2019 at 2:45 PM Ryder Lee wrote: > > > > Add SPDX identifiers to all remaining files in mt76/ > > > > Signed-off-by: Ryder Lee > > ---