Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 5.3] mt76: mt76x0e: disable 5GHz band for MT7630E
@ 2019-08-13 13:36 Stanislaw Gruszka
       [not found] ` <20190813175526.CCBC220840@mail.kernel.org>
  2019-09-03 13:49 ` Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2019-08-13 13:36 UTC (permalink / raw)
  To: linux-wireless; +Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Roy Luo

MT7630E hardware does support 5GHz, but we do not properly configure phy
for 5GHz channels. Scanning at this band not only do not show any APs
but also can hang the firmware.

Since vendor reference driver do not support 5GHz we don't know how
properly configure 5GHz channels. So disable this band for MT7630E .

Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c
index ab6dfc026acb..36918b1bd653 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c
@@ -67,6 +67,11 @@ static void mt76x0_set_chip_cap(struct mt76x02_dev *dev)
 		dev_dbg(dev->mt76.dev, "mask out 2GHz support\n");
 	}
 
+	if (is_mt7630(dev)) {
+		dev->mt76.cap.has_5ghz = false;
+		dev_dbg(dev->mt76.dev, "mask out 5GHz support\n");
+	}
+
 	if (!mt76x02_field_valid(nic_conf1 & 0xff))
 		nic_conf1 &= 0xff00;
 
-- 
1.9.3


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 5.3] mt76: mt76x0e: disable 5GHz band for MT7630E
       [not found] ` <20190813175526.CCBC220840@mail.kernel.org>
@ 2019-08-14  8:54   ` Stanislaw Gruszka
  0 siblings, 0 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2019-08-14  8:54 UTC (permalink / raw)
  To: Sasha Levin; +Cc: linux-wireless, Felix Fietkau, stable

On Tue, Aug 13, 2019 at 05:55:26PM +0000, Sasha Levin wrote:
> Hi,
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
> 
> The bot has tested the following trees: v5.2.8, v4.19.66, v4.14.138, v4.9.189, v4.4.189.
> 
> v5.2.8: Build OK!
> v4.19.66: Failed to apply! Possible dependencies:
>     86c71d3deefa ("mt76: move eeprom utility routines in mt76x02_eeprom.h")
>     d6500cf3700f ("mt76x0: add quirk to disable 2.4GHz band for Archer T1U")
>     eef40d209ad0 ("mt76: move common eeprom definitions in mt76x02-lib module")
<snip>
> NOTE: The patch will not be queued to stable trees until it is upstream.
> 
> How should we proceed with this patch?

mt76x0e support was added in 4.20 , so it's fine just to apply this
commit in 5.2 .

Stanislaw 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 5.3] mt76: mt76x0e: disable 5GHz band for MT7630E
  2019-08-13 13:36 [PATCH 5.3] mt76: mt76x0e: disable 5GHz band for MT7630E Stanislaw Gruszka
       [not found] ` <20190813175526.CCBC220840@mail.kernel.org>
@ 2019-09-03 13:49 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-09-03 13:49 UTC (permalink / raw)
  To: Stanislaw Gruszka
  Cc: linux-wireless, Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Roy Luo

Stanislaw Gruszka <sgruszka@redhat.com> wrote:

> MT7630E hardware does support 5GHz, but we do not properly configure phy
> for 5GHz channels. Scanning at this band not only do not show any APs
> but also can hang the firmware.
> 
> Since vendor reference driver do not support 5GHz we don't know how
> properly configure 5GHz channels. So disable this band for MT7630E .
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>

Patch applied to wireless-drivers.git, thanks.

70702265a04a mt76: mt76x0e: disable 5GHz band for MT7630E

-- 
https://patchwork.kernel.org/patch/11092285/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 13:36 [PATCH 5.3] mt76: mt76x0e: disable 5GHz band for MT7630E Stanislaw Gruszka
     [not found] ` <20190813175526.CCBC220840@mail.kernel.org>
2019-08-14  8:54   ` Stanislaw Gruszka
2019-09-03 13:49 ` Kalle Valo

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org linux-wireless@archiver.kernel.org
	public-inbox-index linux-wireless


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/ public-inbox