From: zhengbin <zhengbin13@huawei.com>
To: <Jes.Sorensen@gmail.com>, <kvalo@codeaurora.org>,
<davem@davemloft.net>, <linux-wireless@vger.kernel.org>,
<netdev@vger.kernel.org>
Cc: <zhengbin13@huawei.com>
Subject: [PATCH -next v2] rtl8xxxu: Remove set but not used variable 'vif','dev','len'
Date: Tue, 19 Nov 2019 10:25:14 +0800 [thread overview]
Message-ID: <1574130314-25626-1-git-send-email-zhengbin13@huawei.com> (raw)
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5396:24: warning: variable vif set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5397:17: warning: variable dev set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5400:6: warning: variable len set but not used [-Wunused-but-set-variable]
They are introduced by commit e542e66b7c2e ("rtl8xxxu:
add bluetooth co-existence support for single antenna"), but never used,
so remove them.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
v1->v2: modify comment, it --> they
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 1d94cab..aa2bb2a 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -5393,18 +5393,13 @@ static void rtl8xxxu_c2hcmd_callback(struct work_struct *work)
{
struct rtl8xxxu_priv *priv;
struct rtl8723bu_c2h *c2h;
- struct ieee80211_vif *vif;
- struct device *dev;
struct sk_buff *skb = NULL;
unsigned long flags;
- int len;
u8 bt_info = 0;
struct rtl8xxxu_btcoex *btcoex;
priv = container_of(work, struct rtl8xxxu_priv, c2hcmd_work);
- vif = priv->vif;
btcoex = &priv->bt_coex;
- dev = &priv->udev->dev;
if (priv->rf_paths > 1)
goto out;
@@ -5415,7 +5410,6 @@ static void rtl8xxxu_c2hcmd_callback(struct work_struct *work)
spin_unlock_irqrestore(&priv->c2hcmd_lock, flags);
c2h = (struct rtl8723bu_c2h *)skb->data;
- len = skb->len - 2;
switch (c2h->id) {
case C2H_8723B_BT_INFO:
--
2.7.4
next reply other threads:[~2019-11-19 2:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 2:25 zhengbin [this message]
2019-11-19 3:27 ` [PATCH -next v2] rtl8xxxu: Remove set but not used variable 'vif','dev','len' Chris Chiu
2019-11-20 7:48 ` [PATCH -next v2] rtl8xxxu: Remove set but not used variable 'vif', 'dev', 'len' Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574130314-25626-1-git-send-email-zhengbin13@huawei.com \
--to=zhengbin13@huawei.com \
--cc=Jes.Sorensen@gmail.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).