From: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
To: linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <wright.feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
Raveendran Somu <raveendran.somu@cypress.com>,
Chi-hsien Lin <chi-hsien.lin@cypress.com>
Subject: [PATCH 2/6] brcmfmac: Fix double freeing in the fmac usb data path
Date: Thu, 13 Feb 2020 02:44:32 -0600 [thread overview]
Message-ID: <1581583476-60155-3-git-send-email-chi-hsien.lin@cypress.com> (raw)
In-Reply-To: <1581583476-60155-1-git-send-email-chi-hsien.lin@cypress.com>
From: Raveendran Somu <raveendran.somu@cypress.com>
When the brcmf_fws_process_skb() fails to get hanger slot for
queuing the skb, it tries to free the skb.
But the caller brcmf_netdev_start_xmit() of that funciton frees
the packet on error return value.
This causes the double freeing and which caused the kernel crash.
Signed-off-by: Raveendran Somu <raveendran.somu@cypress.com>
Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
index 5e1a11c07551..10022c765354 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
@@ -2145,8 +2145,7 @@ int brcmf_fws_process_skb(struct brcmf_if *ifp, struct sk_buff *skb)
brcmf_fws_enq(fws, BRCMF_FWS_SKBSTATE_DELAYED, fifo, skb);
brcmf_fws_schedule_deq(fws);
} else {
- bphy_err(drvr, "drop skb: no hanger slot\n");
- brcmf_txfinalize(ifp, skb, false);
+ bphy_err(drvr, "no hanger slot available\n");
rc = -ENOMEM;
}
brcmf_fws_unlock(fws);
--
2.1.0
next prev parent reply other threads:[~2020-02-13 8:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 8:44 [PATCH 0/6] brcmfmac: USB change series Chi-Hsien Lin
2020-02-13 8:44 ` [PATCH 1/6] brcmfmac: Fix driver crash on USB control transfer timeout Chi-Hsien Lin
2020-03-12 13:18 ` Kalle Valo
2020-02-13 8:44 ` Chi-Hsien Lin [this message]
2020-02-13 8:44 ` [PATCH 3/6] brcmfmac: fix the incorrect return value in brcmf_inform_single_bss() Chi-Hsien Lin
2020-02-13 9:30 ` Arend Van Spriel
2020-02-14 14:56 ` Chi-Hsien Lin
2020-02-13 8:44 ` [PATCH 4/6] brcmfmac: increase max hanger slots from 1K to 3K in fws layer Chi-Hsien Lin
2020-02-13 8:44 ` [PATCH 5/6] brcmfmac: add USB autosuspend feature support Chi-Hsien Lin
2020-02-13 9:36 ` Arend Van Spriel
2020-02-17 12:06 ` Chi-Hsien Lin
2020-02-13 8:44 ` [PATCH 6/6] brcmfmac: To support printing USB console messages Chi-Hsien Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581583476-60155-3-git-send-email-chi-hsien.lin@cypress.com \
--to=chi-hsien.lin@cypress.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=raveendran.somu@cypress.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).