linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ssreeela@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Lei Wang <leiwa@codeaurora.org>, Rick Wu <rwu@codeaurora.org>,
	linux-wireless@vger.kernel.org,
	Sebastian Gottschall <s.gottschall@dd-wrt.com>,
	ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: enable VHT160 and VHT80+80 modes
Date: Mon, 30 Mar 2020 14:52:53 +0530	[thread overview]
Message-ID: <158d2bdf5027a494d14cfdd6134b9c6f@codeaurora.org> (raw)
In-Reply-To: <87bloi2g6h.fsf@kamboji.qca.qualcomm.com>

On 2020-03-27 16:55, Kalle Valo wrote:
> ssreeela@codeaurora.org writes:
> 
>> On 2020-03-26 15:29, Kalle Valo wrote:
>>> Sowmiya Sree Elavalagan <ssreeela@codeaurora.org> wrote:
>>> 
>>>> From: Lei Wang <leiwa@codeaurora.org>
>>>> 
>>>> Set right channel frequencies in VHT160 mode according to the VHT160
>>>> interoperability workaround added as part of IEEE Std 802.11™-2016 
>>>> in
>>>> "Table 9-252—VHT Operation Information subfields", band_center_freq2
>>>> corresponds to CCFS1 in Table 9-253. Previous implementation
>>>> (band_center_freq2 = 0 for VHT160) is only deprecated.
>>>> 
>>>> Enable VHT80+80 mode and set the proper peer RX nss value for
>>>> VHT160 and
>>>> VHT80+80 mode.
>>>> 
>>>> Based on patches by Sebastian Gottschall:
>>>> 
>>>> https://lkml.kernel.org/r/20180704095444.662-1-s.gottschall@dd-wrt.com
>>>> 
>>>> https://lkml.kernel.org/r/20180704120519.6479-1-s.gottschall@dd-wrt.com
>>>> 
>>>> Tested: qca9984 with firmware ver 10.4-3.10-00047
>>>> 
>>>> Co-developed-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
>>>> Signed-off-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
>>>> Co-developed-by: Rick Wu <rwu@codeaurora.org>
>>>> Signed-off-by: Rick Wu <rwu@codeaurora.org>
>>>> Signed-off-by: Lei Wang <leiwa@codeaurora.org>
>>>> Signed-off-by: Sowmiya Sree Elavalagan <ssreeela@codeaurora.org>
>>> 
>>> Fails to build on GCC 8.1. Did you test this?
>>> 
>>> In file included from ./include/asm-generic/bug.h:5,
>>>                  from ./arch/x86/include/asm/bug.h:83,
>>>                  from ./include/linux/bug.h:5,
>>>                  from ./include/net/mac80211.h:16,
>>>                  from drivers/net/wireless/ath/ath10k/mac.h:10,
>>>                  from drivers/net/wireless/ath/ath10k/mac.c:8:
>>> In function 'ath10k_peer_assoc_h_vht',
>>>     inlined from 'ath10k_peer_assoc_prepare' at
>>> drivers/net/wireless/ath/ath10k/mac.c:2790:2:
>>> ./include/linux/compiler.h:350:38: error: call to
>>> '__compiletime_assert_2631' declared with attribute error:
> 
> [...]
> 
>> I checked the build. Build was successful with GCC version 4.8.
>> Will fix the error and update the patch.
> 
> Great, thanks. Here's how I installed GCC 8.1 from crosstool:
> 
> listings: https://www.kernel.org/pub/tools/crosstool/
> 
> wget
> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/x86_64-gcc-8.1.0-nolibc-x86_64-linux.tar.xz
> pushd /opt/cross/
> tar -xf ~/tmp/crosstool/x86_64-gcc-8.1.0-nolibc-x86_64-linux.tar.xz
> 
> In top level create GNUMakefile:
> 
> CROSS_COMPILE=/opt/cross/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-
> include Makefile

Thanks for the info. Will check the build with GCC 8.1 and resend.

Regards,
Sowmiya Sree

      reply	other threads:[~2020-03-30  9:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 14:56 [PATCH] ath10k: enable VHT160 and VHT80+80 modes Sowmiya Sree Elavalagan
2020-03-26  9:59 ` Kalle Valo
     [not found] ` <20200326095907.5326BC433BA@smtp.codeaurora.org>
2020-03-26 13:15   ` ssreeela
2020-03-27 11:25     ` Kalle Valo
2020-03-30  9:22       ` ssreeela [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158d2bdf5027a494d14cfdd6134b9c6f@codeaurora.org \
    --to=ssreeela@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@codeaurora.org \
    --cc=leiwa@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rwu@codeaurora.org \
    --cc=s.gottschall@dd-wrt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).