From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Ping-Ke Shih" <pkshih@realtek.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Fix non-kerneldoc comment in realtek/rtlwifi/usb.c
Date: Wed, 7 Aug 2019 21:07:40 -0500 [thread overview]
Message-ID: <15df2564-8815-f351-8fb2-b46611a90234@lwfinger.net> (raw)
In-Reply-To: <34195.1565229118@turing-police>
On 8/7/19 8:51 PM, Valdis Klētnieks wrote:
> Fix spurious warning message when building with W=1:
>
> CC [M] drivers/net/wireless/realtek/rtlwifi/usb.o
> drivers/net/wireless/realtek/rtlwifi/usb.c:243: warning: Cannot understand * on line 243 - I thought it was a doc line
> drivers/net/wireless/realtek/rtlwifi/usb.c:760: warning: Cannot understand * on line 760 - I thought it was a doc line
> drivers/net/wireless/realtek/rtlwifi/usb.c:790: warning: Cannot understand * on line 790 - I thought it was a doc line
>
> Clean up the comment format.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>
> ---
> Changes since v1: Larry Finger pointed out the patch wasn't checkpatch-clean.
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c
> index 34d68dbf4b4c..4b59f3b46b28 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/usb.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/usb.c
> @@ -239,10 +239,7 @@ static void _rtl_usb_io_handler_release(struct ieee80211_hw *hw)
> mutex_destroy(&rtlpriv->io.bb_mutex);
> }
>
> -/**
> - *
> - * Default aggregation handler. Do nothing and just return the oldest skb.
> - */
> +/* Default aggregation handler. Do nothing and just return the oldest skb. */
> static struct sk_buff *_none_usb_tx_aggregate_hdl(struct ieee80211_hw *hw,
> struct sk_buff_head *list)
> {
> @@ -756,11 +753,6 @@ static int rtl_usb_start(struct ieee80211_hw *hw)
> return err;
> }
>
> -/**
> - *
> - *
> - */
> -
> /*======================= tx =========================================*/
> static void rtl_usb_cleanup(struct ieee80211_hw *hw)
> {
> @@ -786,11 +778,7 @@ static void rtl_usb_cleanup(struct ieee80211_hw *hw)
> usb_kill_anchored_urbs(&rtlusb->tx_submitted);
> }
>
> -/**
> - *
> - * We may add some struct into struct rtl_usb later. Do deinit here.
> - *
> - */
> +/* We may add some struct into struct rtl_usb later. Do deinit here. */
> static void rtl_usb_deinit(struct ieee80211_hw *hw)
> {
> rtl_usb_cleanup(hw);
I missed that the subject line should be "rtwifi: Fix ....". Otherwise it is OK.
Larry
next prev parent reply other threads:[~2019-08-08 2:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 1:51 [PATCH v2] Fix non-kerneldoc comment in realtek/rtlwifi/usb.c Valdis Klētnieks
2019-08-08 2:07 ` Larry Finger [this message]
2019-08-08 7:10 ` Kalle Valo
2019-08-08 8:14 ` Larry Finger
2019-09-03 13:06 ` [PATCH v2] rtlwifi: fix non-kerneldoc comment in usb.c Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15df2564-8815-f351-8fb2-b46611a90234@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).