* [PATCH v2] mac80211: choose first enabled channel for monitor
@ 2021-03-11 5:29 Karthikeyan Kathirvel
0 siblings, 0 replies; only message in thread
From: Karthikeyan Kathirvel @ 2021-03-11 5:29 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, ath11k, Karthikeyan Kathirvel
Though the first channel from sband channel list is invalid
or disabled still mac80211 is choosing this disabled channel
as a default channel for monitor interface. This will end-up
in choosing wrong channel.
Fixed by assigning the first available valid or enabled channel
to the respective radios.
Signed-off-by: Karthikeyan Kathirvel <kathirve@codeaurora.org>
---
v2:
Addressed review comments on changing the subject
net/mac80211/main.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/net/mac80211/main.c b/net/mac80211/main.c
index 4f3f8bb..1f8a5eb 100644
--- a/net/mac80211/main.c
+++ b/net/mac80211/main.c
@@ -973,8 +973,15 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
continue;
if (!dflt_chandef.chan) {
+ /*
+ * Assigning the first enabled channel to dflt_chandef from the
+ * list of channels available specific to country
+ */
+ for (i = 0; i < sband->n_channels; i++)
+ if (!(sband->channels[i].flags & IEEE80211_CHAN_DISABLED))
+ break;
cfg80211_chandef_create(&dflt_chandef,
- &sband->channels[0],
+ &sband->channels[i == sband->n_channels ? 0 : i],
NL80211_CHAN_NO_HT);
/* init channel we're on */
if (!local->use_chanctx && !local->_oper_chandef.chan) {
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-11 5:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11 5:29 [PATCH v2] mac80211: choose first enabled channel for monitor Karthikeyan Kathirvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).