From: Kalle Valo <kvalo@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
bryan.odonoghue@linaro.org,
Loic Poulain <loic.poulain@linaro.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] wcn36xx: Fix tx_status mechanism
Date: Mon, 18 Oct 2021 12:47:37 +0000 (UTC) [thread overview]
Message-ID: <163456125238.11105.17236254354491324059.kvalo@codeaurora.org> (raw)
In-Reply-To: <1634560260-15056-1-git-send-email-loic.poulain@linaro.org>
Loic Poulain <loic.poulain@linaro.org> wrote:
> This change fix the TX ack mechanism in various ways:
>
> - For NO_ACK tagged packets, we don't need to way for TX_ACK indication
> and so are not subject to the single packet ack limitation. So we don't
> have to stop the tx queue, and can call the tx status callback as soon
> as DMA transfer has completed.
>
> - Fix skb ownership/reference. Only start status indication timeout
> once the DMA transfer has been completed. This avoids the skb to be
> both referenced in the DMA tx ring and by the tx_ack_skb pointer,
> preventing any use-after-free or double-free.
>
> - This adds a sanity (paranoia?) check on the skb tx ack pointer.
>
> - Resume TX queue if TX status tagged packet TX fails.
>
> Cc: stable@vger.kernel.org
> Fixes: fdf21cc37149 ("wcn36xx: Add TX ack support")
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Fails to build:
drivers/net/wireless/ath/wcn36xx/txrx.c: In function 'wcn36xx_start_tx':
drivers/net/wireless/ath/wcn36xx/txrx.c:611:23: error: unused variable 'flags' [-Werror=unused-variable]
611 | unsigned long flags;
| ^~~~~
cc1: all warnings being treated as errors
make[5]: *** [scripts/Makefile.build:277: drivers/net/wireless/ath/wcn36xx/txrx.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [scripts/Makefile.build:540: drivers/net/wireless/ath/wcn36xx] Error 2
make[3]: *** [scripts/Makefile.build:540: drivers/net/wireless/ath] Error 2
make[2]: *** [scripts/Makefile.build:540: drivers/net/wireless] Error 2
make[1]: *** [scripts/Makefile.build:540: drivers/net] Error 2
make: *** [Makefile:1874: drivers] Error 2
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/1634560260-15056-1-git-send-email-loic.poulain@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-10-18 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 12:31 [PATCH] wcn36xx: Fix tx_status mechanism Loic Poulain
2021-10-18 12:47 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163456125238.11105.17236254354491324059.kvalo@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=stable@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).