From: Kalle Valo <kvalo@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
bryan.odonoghue@linaro.org,
Loic Poulain <loic.poulain@linaro.org>
Subject: Re: [PATCH] wcn36xx: Add chained transfer support for AMSDU
Date: Mon, 25 Oct 2021 13:22:08 +0000 (UTC) [thread overview]
Message-ID: <163516812328.10163.3396652728924346112.kvalo@codeaurora.org> (raw)
In-Reply-To: <1634557705-11120-1-git-send-email-loic.poulain@linaro.org>
Loic Poulain <loic.poulain@linaro.org> wrote:
> WCNSS RX DMA transfer support is limited to 3872 bytes, which is
> enough for simple MPDUs (single MSDU), but not enough for cases
> with A-MSDU (depending on max AMSDU size or max MPDU size).
>
> In that case the MPDU is spread over multiple transfers, with the
> first transfer containing the MPDU header and (at least) the first
> A-MSDU subframe and additional transfer(s) containing the following
> A-MSDUs. This can be handled with a series of flags to tagging the
> first and last A-MSDU transfers.
>
> In that case we have to bufferize and re-linearize the A-MSDU buffers
> into a proper MPDU skb before forwarding to mac80211 (in the same way
> as it is done in ath10k).
>
> This change also includes sanity check of the buffer descriptor to
> prevent skb overflow.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Loic, what should I do with this patch? Bryan is hesitant but I
would be fine to take this. You have to decide :)
--
https://patchwork.kernel.org/project/linux-wireless/patch/1634557705-11120-1-git-send-email-loic.poulain@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-10-25 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 11:48 [PATCH] wcn36xx: Add chained transfer support for AMSDU Loic Poulain
2021-10-18 21:46 ` Bryan O'Donoghue
2021-10-25 13:22 ` Kalle Valo [this message]
2021-10-25 15:46 ` Loic Poulain
2021-10-25 15:39 ` Bryan O'Donoghue
2021-10-25 18:28 ` Kalle Valo
2021-10-27 7:42 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163516812328.10163.3396652728924346112.kvalo@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).