From: Kalle Valo <kvalo@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
bryan.odonoghue@linaro.org,
Loic Poulain <loic.poulain@linaro.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] wcn36xx: Fix (QoS) null data frame bitrate/modulation
Date: Mon, 25 Oct 2021 13:23:19 +0000 (UTC) [thread overview]
Message-ID: <163516819581.10163.12878239371445987189.kvalo@codeaurora.org> (raw)
In-Reply-To: <1634560399-15290-1-git-send-email-loic.poulain@linaro.org>
Loic Poulain <loic.poulain@linaro.org> wrote:
> We observe unexpected connection drops with some APs due to
> non-acked mac80211 generated null data frames (keep-alive).
> After debugging and capture, we noticed that null frames are
> submitted at standard data bitrate and that the given APs are
> in trouble with that.
>
> After setting the null frame bitrate to control bitrate, all
> null frames are acked as expected and connection is maintained.
>
> Not sure if it's a requirement of the specification, but it seems
> the right thing to do anyway, null frames are mostly used for control
> purpose (power-saving, keep-alive...), and submitting them with
> a slower/simpler bitrate/modulation is more robust.
>
> Cc: stable@vger.kernel.org
> Fixes: 512b191d9652 ("wcn36xx: Fix TX data path")
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
d3fd2c95c1c1 wcn36xx: Fix (QoS) null data frame bitrate/modulation
--
https://patchwork.kernel.org/project/linux-wireless/patch/1634560399-15290-1-git-send-email-loic.poulain@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-10-25 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 12:33 [PATCH] wcn36xx: Fix (QoS) null data frame bitrate/modulation Loic Poulain
2021-10-25 13:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163516819581.10163.12878239371445987189.kvalo@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=stable@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).