From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
wgong@codeaurora.org
Subject: Re: [PATCH] ath11k: remove return for empty tx bitrate in mac_op_sta_statistics
Date: Mon, 15 Nov 2021 09:23:37 +0000 (UTC) [thread overview]
Message-ID: <163696821403.13305.6349062465191543646.kvalo@codeaurora.org> (raw)
In-Reply-To: <20211011084957.31024-1-wgong@codeaurora.org>
Wen Gong <wgong@codeaurora.org> wrote:
> Currently in ath11k_mac_op_sta_statistics() there is the following
> logic:
>
> if (!arsta->txrate.legacy && !arsta->txrate.nss)
> return;
>
> Unfortunately if this condition is true then the function returns without
> setting parameters that follow the txrate. To address this issue remove the
> return and instead invert the logic to set the txrate logic if
> (arsta->txrate.legacy || arsta->txrate.nss).
>
> The same was done also in ath10k in commit 1cd6ba8ae33e ("ath10k: remove return
> for NL80211_STA_INFO_TX_BITRATE").
>
> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
1d795645e1ee ath11k: remove return for empty tx bitrate in mac_op_sta_statistics
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211011084957.31024-1-wgong@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-11-15 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 8:49 [PATCH] ath11k: remove return for empty tx bitrate in mac_op_sta_statistics Wen Gong
2021-11-15 9:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163696821403.13305.6349062465191543646.kvalo@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).