From: Kalle Valo <kvalo@codeaurora.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: <linux-wireless@vger.kernel.org>, <tiwai@suse.de>,
<Larry.Finger@lwfinger.net>
Subject: Re: [PATCH v3 1/3] rtw89: update partition size of firmware header on skb->data
Date: Mon, 22 Nov 2021 18:42:34 +0000 (UTC) [thread overview]
Message-ID: <163760654946.7371.10993435866062669169.kvalo@codeaurora.org> (raw)
In-Reply-To: <20211119054512.10620-2-pkshih@realtek.com>
Ping-Ke Shih <pkshih@realtek.com> wrote:
> The partition size is used to tell hardware the size of piece we are going
> to send a firmware. The old code updates the size in constant buffer of
> firmware, and leads system crash.
>
> To fix this, update the size on skb->data after we copy the firmware data
> into skb.
>
> Buglink: https://bugzilla.opensuse.org/show_bug.cgi?id=1188303
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Reported-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> Tested-by: Takashi Iwai <tiwai@suse.de>
> Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Patch applied to wireless-drivers.git, thanks.
5737b4515dee rtw89: update partition size of firmware header on skb->data
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211119054512.10620-2-pkshih@realtek.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-11-22 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 5:45 [PATCH v3 0/3] rtw89: fix crash when loading firmware file on certain platforms Ping-Ke Shih
2021-11-19 5:45 ` [PATCH v3 1/3] rtw89: update partition size of firmware header on skb->data Ping-Ke Shih
2021-11-22 18:42 ` Kalle Valo [this message]
2021-11-19 5:45 ` [PATCH v3 2/3] rtw89: add const in the cast of le32_get_bits() Ping-Ke Shih
2021-11-26 16:04 ` Kalle Valo
2021-12-08 18:26 ` Kalle Valo
2021-11-19 5:45 ` [PATCH v3 3/3] rtw89: use inline function instead macro to set H2C and CAM Ping-Ke Shih
2021-11-19 12:05 ` [PATCH v3 0/3] rtw89: fix crash when loading firmware file on certain platforms Kalle Valo
2021-11-19 13:56 ` Takashi Iwai
2021-11-22 0:22 ` Pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163760654946.7371.10993435866062669169.kvalo@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).