From: Kalle Valo <kvalo@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
Loic Poulain <loic.poulain@linaro.org>
Subject: Re: [PATCH] wcn36xx: Use correct SSN for ADD BA request
Date: Fri, 26 Nov 2021 10:19:37 +0000 (UTC) [thread overview]
Message-ID: <163792197409.23943.7303108798447763543.kvalo@codeaurora.org> (raw)
In-Reply-To: <1637604251-11763-1-git-send-email-loic.poulain@linaro.org>
Loic Poulain <loic.poulain@linaro.org> wrote:
> Since firmware uses its own sequence number counters, we need to
> use firmware number as well when mac80211 generates the ADD_BA
> request packet. Indeed the firmware sequence counters tend to
> slightly drift from the mac80211 ones because of firmware offload
> features like ARP responses. This causes the starting sequence
> number field of the ADD_BA request to be unaligned, and can possibly
> cause issues with strict/picky APs.
>
> To fix this, we retrieve the current firmware sequence number for
> a given TID through the smd_trigger_ba API, and use that number as
> replacement of the mac80211 starting sequence number.
>
> This change also ensures that any issue in the smd *ba procedures
> will cause the ba action to properly fail, and remove useless call
> to smd_trigger_ba() from IEEE80211_AMPDU_RX_START.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
23cddeb5a770 wcn36xx: Use correct SSN for ADD BA request
--
https://patchwork.kernel.org/project/linux-wireless/patch/1637604251-11763-1-git-send-email-loic.poulain@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-11-26 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 18:04 [PATCH] wcn36xx: Use correct SSN for ADD BA request Loic Poulain
2021-11-26 10:19 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163792197409.23943.7303108798447763543.kvalo@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).