From: Kalle Valo <kvalo@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] ath11k: remove redundant assignment to variables vht_mcs and he_mcs
Date: Tue, 10 May 2022 16:34:24 +0000 (UTC) [thread overview]
Message-ID: <165220046267.6768.5493678781221358887.kvalo@kernel.org> (raw)
In-Reply-To: <20220507184155.26939-1-colin.i.king@gmail.com>
Colin Ian King <colin.i.king@gmail.com> wrote:
> The variables vht_mcs and he_mcs are being initialized in the
> start of for-loops however they are re-assigned new values in
> the loop and not used outside the loop. The initializations
> are redundant and can be removed.
>
> Cleans up clang scan warnings:
>
> warning: Although the value stored to 'vht_mcs' is used in the
> enclosing expression, the value is never actually read from
> 'vht_mcs' [deadcode.DeadStores]
>
> warning: Although the value stored to 'he_mcs' is used in the
> enclosing expression, the value is never actually read from
> 'he_mcs' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
25c321e8534e ath11k: remove redundant assignment to variables vht_mcs and he_mcs
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220507184155.26939-1-colin.i.king@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-05-10 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 18:41 [PATCH] ath11k: remove redundant assignment to variables vht_mcs and he_mcs Colin Ian King
2022-05-10 16:34 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165220046267.6768.5493678781221358887.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).