From: Ping-Ke Shih <pkshih@realtek.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>
Cc: "Jes.Sorensen@gmail.com" <Jes.Sorensen@gmail.com>
Subject: Re: [PATCH v2 1/4] wifi: rtl8xxxu: Register the LED and make it blink
Date: Sat, 21 Jan 2023 07:01:36 +0000 [thread overview]
Message-ID: <16551886fea8b46cddd18659b43a54564b30ace2.camel@realtek.com> (raw)
In-Reply-To: <b8235bca-60c3-d0fe-a958-53c6dd3ba3f6@gmail.com>
On Fri, 2023-01-20 at 17:51 +0200, Bitterblue Smith wrote:
> If the chip can have an LED, register a struct led_classdev and enable
> hardware-controlled blinking. When the chip is not transmitting or
> receiving anything the LED is off. Otherwise the LED will blink
> faster or slower according to the throughput.
>
> The LED can be controlled from userspace by writing 0, 1, or 2 to
> /sys/class/leds/rtl8xxxu-usbX-Y/brightness:
> 0 - solid off.
> 1 - solid on.
> 2 - hardware-controlled blinking.
>
> In this patch none of the chips advertise having an LED. That will be
> added in the next patches.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> v2:
> - Suggestion from Ping-Ke Shih:
> - Check for led_classdev_brightness_set inside rtl8xxxu_init_led()
> and for led_registered inside rtl8xxxu_deinit_led() instead of
> checking for them in the caller functions.
>
[...]
next prev parent reply other threads:[~2023-01-21 7:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 15:51 [PATCH v2 1/4] wifi: rtl8xxxu: Register the LED and make it blink Bitterblue Smith
2023-01-20 15:52 ` [PATCH v2 2/4] wifi: rtl8xxxu: Add LED control code for RTL8188EU Bitterblue Smith
2023-01-21 7:02 ` Ping-Ke Shih
2023-01-20 15:54 ` [PATCH v2 3/4] wifi: rtl8xxxu: Add LED control code for RTL8192EU Bitterblue Smith
2023-01-21 7:03 ` Ping-Ke Shih
2023-01-20 15:55 ` [PATCH v2 4/4] wifi: rtl8xxxu: Add LED control code for RTL8723AU Bitterblue Smith
2023-01-21 7:03 ` Ping-Ke Shih
2023-01-21 7:01 ` Ping-Ke Shih [this message]
2023-02-13 17:24 ` [PATCH v2 1/4] wifi: rtl8xxxu: Register the LED and make it blink Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16551886fea8b46cddd18659b43a54564b30ace2.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).