From: Kalle Valo <kvalo@kernel.org>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Aditya Kumar Singh <quic_adisi@quicinc.com>
Subject: Re: [PATCH] wifi: ath11k: fix firmware assert during bandwidth change for peer sta
Date: Wed, 12 Oct 2022 06:39:29 +0000 (UTC) [thread overview]
Message-ID: <166555676816.24262.18337479750869695639.kvalo@kernel.org> (raw)
In-Reply-To: <20221005095430.19890-1-quic_adisi@quicinc.com>
Aditya Kumar Singh <quic_adisi@quicinc.com> wrote:
> Currently, ath11k sends peer assoc command for each peer to
> firmware when bandwidth changes. Peer assoc command is a
> bulky command and if many clients are connected, this could
> lead to firmware buffer getting overflowed leading to a firmware
> assert.
>
> However, during bandwidth change, only phymode and bandwidth
> also can be updated by WMI set peer param command. This makes
> the overall command light when compared to peer assoc and for
> multi-client cases, firmware buffer overflow also does not
> occur.
>
> Remove sending peer assoc command during sta bandwidth change
> and instead add sending WMI set peer param command for phymode
> and bandwidth.
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
>
> Fixes: f187fe8e3bc65 ("ath11k: fix firmware crash during channel switch")
> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
3ff51d7416ee wifi: ath11k: fix firmware assert during bandwidth change for peer sta
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221005095430.19890-1-quic_adisi@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-10-12 6:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 9:54 [PATCH] wifi: ath11k: fix firmware assert during bandwidth change for peer sta Aditya Kumar Singh
2022-10-12 6:39 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166555676816.24262.18337479750869695639.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_adisi@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).