* [PATCH] ipw2x00: remove unused _ipw_read16 function
@ 2023-03-19 13:54 Tom Rix
2023-03-19 15:21 ` Kalle Valo
2023-03-31 14:44 ` wifi: " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-19 13:54 UTC (permalink / raw)
To: stas.yakovlev, kvalo, davem, edumazet, kuba, pabeni, nathan,
ndesaulniers
Cc: linux-wireless, netdev, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/net/wireless/intel/ipw2x00/ipw2200.c:381:19: error:
unused function '_ipw_read16' [-Werror,-Wunused-function]
static inline u16 _ipw_read16(struct ipw_priv *ipw, unsigned long ofs)
^
This function and its wrapping marco are not used, so remove them.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/wireless/intel/ipw2x00/ipw2200.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
index b91b1a2d0be7..dfe0f74369e6 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
@@ -377,19 +377,6 @@ static inline u8 _ipw_read8(struct ipw_priv *ipw, unsigned long ofs)
_ipw_read8(ipw, ofs); \
})
-/* 16-bit direct read (low 4K) */
-static inline u16 _ipw_read16(struct ipw_priv *ipw, unsigned long ofs)
-{
- return readw(ipw->hw_base + ofs);
-}
-
-/* alias to 16-bit direct read (low 4K of SRAM/regs), with debug wrapper */
-#define ipw_read16(ipw, ofs) ({ \
- IPW_DEBUG_IO("%s %d: read_direct16(0x%08X)\n", __FILE__, __LINE__, \
- (u32)(ofs)); \
- _ipw_read16(ipw, ofs); \
-})
-
/* 32-bit direct read (low 4K) */
static inline u32 _ipw_read32(struct ipw_priv *ipw, unsigned long ofs)
{
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipw2x00: remove unused _ipw_read16 function
2023-03-19 13:54 [PATCH] ipw2x00: remove unused _ipw_read16 function Tom Rix
@ 2023-03-19 15:21 ` Kalle Valo
2023-03-31 14:44 ` wifi: " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-03-19 15:21 UTC (permalink / raw)
To: Tom Rix
Cc: stas.yakovlev, davem, edumazet, kuba, pabeni, nathan,
ndesaulniers, linux-wireless, netdev, linux-kernel, llvm
Tom Rix <trix@redhat.com> writes:
> clang with W=1 reports
> drivers/net/wireless/intel/ipw2x00/ipw2200.c:381:19: error:
> unused function '_ipw_read16' [-Werror,-Wunused-function]
> static inline u16 _ipw_read16(struct ipw_priv *ipw, unsigned long ofs)
> ^
> This function and its wrapping marco are not used, so remove them.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
I'll add "wifi:" to the title.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wifi: ipw2x00: remove unused _ipw_read16 function
2023-03-19 13:54 [PATCH] ipw2x00: remove unused _ipw_read16 function Tom Rix
2023-03-19 15:21 ` Kalle Valo
@ 2023-03-31 14:44 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-03-31 14:44 UTC (permalink / raw)
To: Tom Rix
Cc: stas.yakovlev, davem, edumazet, kuba, pabeni, nathan,
ndesaulniers, linux-wireless, netdev, linux-kernel, llvm,
Tom Rix
Tom Rix <trix@redhat.com> wrote:
> clang with W=1 reports
> drivers/net/wireless/intel/ipw2x00/ipw2200.c:381:19: error:
> unused function '_ipw_read16' [-Werror,-Wunused-function]
> static inline u16 _ipw_read16(struct ipw_priv *ipw, unsigned long ofs)
> ^
> This function and its wrapping marco are not used, so remove them.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Patch applied to wireless-next.git, thanks.
c7e39d70613c wifi: ipw2x00: remove unused _ipw_read16 function
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230319135418.1703380-1-trix@redhat.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-31 14:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-19 13:54 [PATCH] ipw2x00: remove unused _ipw_read16 function Tom Rix
2023-03-19 15:21 ` Kalle Valo
2023-03-31 14:44 ` wifi: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).