Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback

From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: "Kalle Valo" <kvalo@codeaurora.org>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Arend van Spriel" <aspriel@gmail.com>,
	"Franky Lin" <franky.lin@broadcom.com>,
	"Hante Meuleman" <hante.meuleman@broadcom.com>,
	"Chi-hsien Lin" <chi-hsien.lin@infineon.com>,
	"Wright Feng" <wright.feng@infineon.com>,
	"Chung-hsien Hsu" <chung-hsien.hsu@infineon.com>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	SHA-cyfmac-dev-list@infineon.com
Subject: Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback
Date: Sun, 23 May 2021 08:54:48 +0200	[thread overview]
Message-ID: <17998013ac0.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> (raw)
In-Reply-To: <20210523061221.GD29015@dragon>

[-- Attachment #1: Type: text/plain, Size: 2198 bytes --]

On May 23, 2021 8:12:29 AM Shawn Guo <shawn.guo@linaro.org> wrote:

> On Wed, Apr 28, 2021 at 08:42:29PM +0800, Shawn Guo wrote:
>> On Wed, Apr 28, 2021 at 02:03:07PM +0200, Arend van Spriel wrote:
>>> On 4/25/2021 1:02 PM, Shawn Guo wrote:
>>>> Instead of aborting country code setup in firmware, use ISO3166 country
>>>> code and 0 rev as fallback, when country_codes mapping table is not
>>>> configured.  This fallback saves the country_codes table setup for recent
>>>> brcmfmac chipsets/firmwares, which just use ISO3166 code and require no
>>>> revision number.
>>>
>>> I am somewhat surprised, but with the brcm-spinoffs (cypress/infineon and
>>> synaptics) my understanding may have been surpassed by reality. Would you
>>> happen to know which chipsets/firmwares require only ISO3166 code and no
>>> rev?
>>
>> The "no rev" here actually means 'rev' field being zero.  The chipset
>> I'm running is a BCM43012 from Synaptics, I think.
>>
>> Firmware: BCM43012/2 wl0: Apr 16 2021 15:25:36 version 18.35.389.63.t2 
>> (wlan=r836194) FWID 01-a8c7bac
>
> Arend,
>
> Does it make sense?  Or is there actually a country code mapping table
> I'm not aware of?

I recall the firmware always include a rev 0 for each country code. I will 
have to ask internally whether that may be used for any chipset. If so, it 
seems reasonable to use rev 0 as fallback when no mapping table is provided.

Regards,
Arend

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]