From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
b43-dev <b43-dev@lists.infradead.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/1] b43: phy_n: Delete some useless empty code
Date: Tue, 11 May 2021 09:11:27 +0800 [thread overview]
Message-ID: <1890aa92-ddf2-78f7-51e7-bdc3a58a04c6@huawei.com> (raw)
In-Reply-To: <YJmRUQwPPDE+hWiN@lunn.ch>
On 2021/5/11 4:02, Andrew Lunn wrote:
> On Mon, May 10, 2021 at 10:51:17PM +0800, Zhen Lei wrote:
>> These TODO empty code are added by
>> commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
>> been more than a decade now. I don't think anyone who wants to perfect
>> this workaround can follow this TODO tip exactly. Instead, it limits them
>> to new thinking. Remove it will be better.
>>
>> No functional change.
>
> No function change, apart from the new warning?
>
> Does your bot to compile the change and look for new warnings/errors?
Sorry, I have compiled it. I guess it's probably separated by macros, which I didn't notice. I will check it.
>
> Andrew
>
> .
>
next prev parent reply other threads:[~2021-05-11 1:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 14:51 [PATCH 1/1] b43: phy_n: Delete some useless empty code Zhen Lei
2021-05-10 17:22 ` kernel test robot
2021-05-10 20:02 ` Andrew Lunn
2021-05-11 1:11 ` Leizhen (ThunderTown) [this message]
2021-05-11 3:00 ` Leizhen (ThunderTown)
2021-05-11 12:04 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1890aa92-ddf2-78f7-51e7-bdc3a58a04c6@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=andrew@lunn.ch \
--cc=b43-dev@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).