From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 0/9] nl80211: add support for PTK/GTK handshake offload
Date: Wed, 3 May 2017 10:29:46 +0200 [thread overview]
Message-ID: <190a84de-7e0a-4012-f1e1-c0dbdbc8c1df@broadcom.com> (raw)
In-Reply-To: <1493799303.2602.6.camel@sipsolutions.net>
On 5/3/2017 10:15 AM, Johannes Berg wrote:
> On Wed, 2017-05-03 at 10:10 +0200, Arend van Spriel wrote:
>>
>> I was asking because we do it for the keys:
>
> correction: the *temporal* keys :)
>
>> /*
>> * Delete all the keys ... pairwise keys can't really
>> * exist any more anyway, but default keys might.
>> */
>> if (rdev->ops->del_key)
>> for (i = 0; i < 6; i++)
>> rdev_del_key(rdev, dev, i, false, NULL);
>>
>> But I guess the comment explains it as PMK is a pairwise (master)
>> key.
>
> Well, not really related, but I basically think we can demand better
> from drivers implementing the new functionality.
Yeah, I do it in brcmfmac. I will mention that demand in CMD_SET_PMK
and/or .set_pmk() description.
Regards,
Arend
prev parent reply other threads:[~2017-05-03 8:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 12:42 [PATCH 0/9] nl80211: add support for PTK/GTK handshake offload Arend van Spriel
2017-05-02 12:42 ` [PATCH 1/9] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK Arend van Spriel
2017-05-02 12:42 ` [PATCH 2/9] cfg80211: support 4-way handshake offloading for 802.1X Arend van Spriel
2017-05-02 12:42 ` [PATCH 3/9] nl80211: add authorized flag to CONNECT event Arend van Spriel
2017-05-02 12:42 ` [PATCH 4/9] nl80211: add authorized flag to ROAM event Arend van Spriel
2017-05-02 12:42 ` [PATCH 5/9] nl80211: remove description about request from NL80211_CMD_ROAM Arend van Spriel
2017-05-02 12:42 ` [PATCH 6/9] brcmfmac: support 4-way handshake offloading for WPA/WPA2-PSK Arend van Spriel
2017-05-02 12:42 ` [PATCH 7/9] brcmfmac: support 4-way handshake offloading for 802.1X Arend van Spriel
2017-05-02 12:42 ` [PATCH 8/9] brcmfmac: switch to using cfg80211_connect_done() Arend van Spriel
2017-05-02 12:42 ` [PATCH 9/9] brcmfmac: provide port authorized state in CONNECT event Arend van Spriel
2017-05-03 5:49 ` [PATCH 0/9] nl80211: add support for PTK/GTK handshake offload Johannes Berg
2017-05-03 8:10 ` Arend van Spriel
2017-05-03 8:15 ` Johannes Berg
2017-05-03 8:29 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=190a84de-7e0a-4012-f1e1-c0dbdbc8c1df@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).