From: Christian Lamparter <chunkeey@gmail.com>
To: Wan Jiabing <wanjiabing@vivo.com>,
Christian Lamparter <chunkeey@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: kael_w@yeah.net
Subject: Re: [PATCH] p54: Remove obsolete comment
Date: Wed, 1 Sep 2021 19:40:00 +0200 [thread overview]
Message-ID: <1ac57e49-30e0-3ca1-c324-3aea2aec598b@gmail.com> (raw)
In-Reply-To: <20210901024744.7013-1-wanjiabing@vivo.com>
On 01/09/2021 04:47, Wan Jiabing wrote:
> In commit d249ff28b1d8 ("intersil: remove obsolete prism54 wireless driver"),
> prism54/isl_oid.h is deleted. The comment here is obsolete.
>
Instead of removing said "obsolete" comment, why not copy the
excellent comment about that "frameburst technology" from the
prism54/isl_oid.h file there?
Cheers,
Christian
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/net/wireless/intersil/p54/fwio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c
> index bece14e4ff0d..1fe072de3e63 100644
> --- a/drivers/net/wireless/intersil/p54/fwio.c
> +++ b/drivers/net/wireless/intersil/p54/fwio.c
> @@ -583,7 +583,6 @@ int p54_set_edcf(struct p54_common *priv)
> rtd = 3 * priv->coverage_class;
> edcf->slottime += rtd;
> edcf->round_trip_delay = cpu_to_le16(rtd);
> - /* (see prism54/isl_oid.h for further details) */
> edcf->frameburst = cpu_to_le16(0);
> edcf->flags = 0;
> memset(edcf->mapping, 0, sizeof(edcf->mapping));
>
prev parent reply other threads:[~2021-09-01 17:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 2:47 [PATCH] p54: Remove obsolete comment Wan Jiabing
2021-09-01 17:40 ` Christian Lamparter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ac57e49-30e0-3ca1-c324-3aea2aec598b@gmail.com \
--to=chunkeey@gmail.com \
--cc=chunkeey@googlemail.com \
--cc=davem@davemloft.net \
--cc=kael_w@yeah.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).